Skip to content

Conversation

@michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Nov 14, 2025

Added some .NET 10 integration tests for traced and buildless (replacing the .NET 10 RC 2 integration tests we ran on Windows and Linux). We do not officially support .NET 10.

@github-actions github-actions bot added the C# label Nov 14, 2025
@michaelnebel michaelnebel marked this pull request as ready for review November 14, 2025 11:36
@michaelnebel michaelnebel requested a review from a team as a code owner November 14, 2025 11:36
Copilot AI review requested due to automatic review settings November 14, 2025 11:36
Copilot finished reviewing on behalf of michaelnebel November 14, 2025 11:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the .NET 10 RC 2 integration tests with .NET 10 final release integration tests. The platform-specific tests (Windows and Linux) are removed in favor of a single all-platforms test that covers both traced and buildless build modes.

  • Removes .NET 10 RC 2 tests from windows/dotnet_10_rc2 and linux/dotnet_10_rc2 directories
  • Adds new .NET 10 final release tests in all-platforms/dotnet_10 directory
  • Tests both traced mode (test1) and buildless mode (test2)

Reviewed Changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
csharp/ql/integration-tests/windows/dotnet_10_rc2/test.py Removed RC 2 test file for Windows
csharp/ql/integration-tests/windows/dotnet_10_rc2/global.json Removed RC 2 SDK configuration for Windows
csharp/ql/integration-tests/windows/dotnet_10_rc2/dotnet_build.csproj Removed RC 2 project file for Windows
csharp/ql/integration-tests/windows/dotnet_10_rc2/Program.cs Removed RC 2 test program for Windows
csharp/ql/integration-tests/linux/dotnet_10_rc2/test.py Removed RC 2 test file for Linux
csharp/ql/integration-tests/linux/dotnet_10_rc2/global.json Removed RC 2 SDK configuration for Linux
csharp/ql/integration-tests/all-platforms/dotnet_10/test.py Added new test with traced and buildless modes for .NET 10 final release
csharp/ql/integration-tests/all-platforms/dotnet_10/global.json Added SDK configuration for .NET 10.0.100 final release
csharp/ql/integration-tests/all-platforms/dotnet_10/dotnet_build.csproj Added .NET 10 project file with net10.0 target framework
csharp/ql/integration-tests/all-platforms/dotnet_10/Program.cs Added simple test program that outputs command-line arguments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +2 to +3
import runs_on

Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runs_on module is imported but never used. Since this test is in the all-platforms directory and the test functions don't have any @runs_on decorators, this import can be removed.

Suggested change
import runs_on

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,8 @@
import os
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The os module is imported but never used in this file. Consider removing this unused import.

Suggested change
import os

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant