-
Notifications
You must be signed in to change notification settings - Fork 1.8k
C#: Initial .NET 10 integration tests. #20837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces the .NET 10 RC 2 integration tests with .NET 10 final release integration tests. The platform-specific tests (Windows and Linux) are removed in favor of a single all-platforms test that covers both traced and buildless build modes.
- Removes .NET 10 RC 2 tests from
windows/dotnet_10_rc2andlinux/dotnet_10_rc2directories - Adds new .NET 10 final release tests in
all-platforms/dotnet_10directory - Tests both traced mode (
test1) and buildless mode (test2)
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
csharp/ql/integration-tests/windows/dotnet_10_rc2/test.py |
Removed RC 2 test file for Windows |
csharp/ql/integration-tests/windows/dotnet_10_rc2/global.json |
Removed RC 2 SDK configuration for Windows |
csharp/ql/integration-tests/windows/dotnet_10_rc2/dotnet_build.csproj |
Removed RC 2 project file for Windows |
csharp/ql/integration-tests/windows/dotnet_10_rc2/Program.cs |
Removed RC 2 test program for Windows |
csharp/ql/integration-tests/linux/dotnet_10_rc2/test.py |
Removed RC 2 test file for Linux |
csharp/ql/integration-tests/linux/dotnet_10_rc2/global.json |
Removed RC 2 SDK configuration for Linux |
csharp/ql/integration-tests/all-platforms/dotnet_10/test.py |
Added new test with traced and buildless modes for .NET 10 final release |
csharp/ql/integration-tests/all-platforms/dotnet_10/global.json |
Added SDK configuration for .NET 10.0.100 final release |
csharp/ql/integration-tests/all-platforms/dotnet_10/dotnet_build.csproj |
Added .NET 10 project file with net10.0 target framework |
csharp/ql/integration-tests/all-platforms/dotnet_10/Program.cs |
Added simple test program that outputs command-line arguments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import runs_on | ||
|
|
Copilot
AI
Nov 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The runs_on module is imported but never used. Since this test is in the all-platforms directory and the test functions don't have any @runs_on decorators, this import can be removed.
| import runs_on |
| @@ -0,0 +1,8 @@ | |||
| import os | |||
Copilot
AI
Nov 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The os module is imported but never used in this file. Consider removing this unused import.
| import os |
Added some .NET 10 integration tests for traced and buildless (replacing the .NET 10 RC 2 integration tests we ran on Windows and Linux). We do not officially support .NET 10.