Skip to content

Conversation

@VikramGoyal23
Copy link

Exercise Review

Exercise Discussion

#57

Checklist

  • If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
  • Have you written unit tests using repo-smith to validate the exercise grading scheme?
  • Have you tested the download script using test-download.sh?
  • Have you verified that this exercise does not already exist or is not currently in review?
  • Did you introduce a new grading mechanism that should belong to git-autograder?
  • Did you introduce a new dependency that should belong to app?

@VikramGoyal23
Copy link
Author

The repo name gitmastery-update-remote-things was chosen so that there would not be a conflict with the repo made for hp-populate-remote

@damithc
Copy link
Contributor

damithc commented Oct 26, 2025

The repo name gitmastery-update-remote-things was chosen so that there would not be a conflict with the repo made for hp-populate-remote

@VikramGoyal23 Each hands-on practical is in its own folder (in the student's computer). So, there will be no conflict when using the same repo name in two HPs.

@VikramGoyal23
Copy link
Author

@damithc Yes, that is correct. I was thinking about the repo that would be made on the student's account.

@damithc
Copy link
Contributor

damithc commented Oct 26, 2025

@damithc Yes, that is correct. I was thinking about the repo that would be made on the student's account.

Good point. My original intention was that the student will run this download script only if s/he doesn't already have the remote repo from the previous HP. If this script gives a different name for the repo, we now have to give two sets of instructions -- one for those continuing with the previous repo, and one for those who ran this download script.

@VikramGoyal23
Copy link
Author

Hmm, good point. However, since this hands-on only involves creating and pushing commits, I don't think that should be an issue? The name of the repo does not seem relevant for either of the hands-on in T2L5. If the student completes hp-populate-remote successfully, they should have no issue ignoring the download instruction for hp-update-remote and pushing their commits.

@damithc
Copy link
Contributor

damithc commented Oct 26, 2025

Hmm, good point. However, since this hands-on only involves creating and pushing commits, I don't think that should be an issue? The name of the repo does not seem relevant for either of the hands-on in T2L5. If the student completes hp-populate-remote successfully, they should have no issue ignoring the download instruction for hp-update-remote and pushing their commits.

Yes @VikramGoyal23 I think it will not be an issue, as the instructions do not involve the name of the remote repo.

@VikramGoyal23
Copy link
Author

@damithc Ah wait, forgive me for my confusion. I didn't consider how my instruction to delete the remote repo would also work in the case the previous exercise was downloaded. Let me push a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants