Fix style CSS properties for RTL languages - #1216
Open
kensnyder wants to merge 1 commit into
Open
Conversation
Properties such as "right" and "margin-end" should use counterparts that work both in LTR languages like English RTL languages like Arabic.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, localized to styling, and directly aligns with the stated RTL/LTR compatibility goal without affecting core logic.
Pull request overview
This PR updates Joyride’s inline styles to use CSS logical properties so button positioning and spacing adapt correctly to both LTR and RTL document directions.
Changes:
- Replaced physical margins (
marginLeft/marginRight) with logical margins (marginInlineStart/marginInlineEnd) for the Back button spacing/alignment. - Replaced
right: 0withinsetInlineEnd: 0so the Close button anchors to the inline end in both LTR and RTL layouts.
File summaries
| File | Description |
|---|---|
| src/styles.ts | Switches key tooltip button styles from physical to logical CSS properties to improve RTL compatibility. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properties such as "right" and "margin-end" should use counterparts that work both in LTR languages like English RTL languages like Arabic.