feat(helm): render oauth.mcpClient.postLoginRedirectAllowlist into config - #989
Merged
Merged
Conversation
…nfig The v1.2.0 binary reads mcpClient.postLoginRedirectAllowlist but the chart config template never emitted it, so the value was dropped and the allowlist stayed empty regardless of Helm values.
QuentinBisson
marked this pull request as ready for review
July 23, 2026 12:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
v1.2.0binary added themcpClient.postLoginRedirectAllowlistconfig field (#978), but the chart'sconfigmap.yamlnever rendered it — themcpClientblock enumeratespublicUrl/clientId/callbackPath/cimdonly. So any Helm value set atmuster.oauth.mcpClient.postLoginRedirectAllowlistwas silently dropped and the allowlist stayed empty, leaving the OAuth proxy start endpoint unable to honor aredirectparameter.This renders the list into the config (default empty, no output) and documents it in
values.yaml.Unblocks the klaus-gateway connector-login completion flow (klaus-gateway#175), which needs muster to 303 the browser back to the gateway's
/connectors/completeafter sign-in.