Fix: Use default_factory for metadata in Message#9
Open
aleLoPrete wants to merge 2 commits intogh0st42:masterfrom
Open
Fix: Use default_factory for metadata in Message#9aleLoPrete wants to merge 2 commits intogh0st42:masterfrom
aleLoPrete wants to merge 2 commits intogh0st42:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Message dataclass was using a mutable default value for the metadata field, preventing the spray-and-wait router from adding messages correctly:
ValueError: mutable default <class 'dict'> for field metadata is not allowed: use default_factoryFix: The metadata field now uses
default_factory=dictto ensure each Message instance receives its own independent dictionary.