cmake : add version.h.in files for whisper and parakeet - #4033
Open
danbev wants to merge 3 commits into
Open
Conversation
This commit adds to version.h.in cmake configure files for whisper.cpp and parakeet.cpp, and removes the current version handling which is using compile flag definitions. This was a mistake on my part when introducing version handling and the reason is that compile definitions become part of the compiler flags for all source files in the target. This meant that when the version is updated the flags will be updated add cause a recompile even if the sources have not changed. parakeet.cpp is given a separate header but shared the version with whisper.cpp at the moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds to version.h.in cmake configure files for whisper.cpp and parakeet.cpp, and removes the current version handling which is using compile flag definitions. This was a mistake on my part when introducing version handling and the reason is that compile definitions become part of the compiler flags for all source files in the target. This meant that when the version is updated the flags will be updated add cause a recompile even if the sources have not changed.
parakeet.cpp is given a separate header but shares the version with whisper.cpp at the moment.
Refs: ggml-org/llama.cpp#28278