[core] Report missing passthrough shader entry points - #10079
Open
ksh368-bit wants to merge 1 commit into
Open
Conversation
ksh368-bit
force-pushed
the
agent/fix-passthrough-empty-entry-points
branch
from
August 15, 2026 04:27
97d5066 to
2c0b799
Compare
ksh368-bit
marked this pull request as ready for review
August 15, 2026 05:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #9993.
Description
When a passthrough shader module had no entry points and the pipeline descriptor omitted the entry-point name, the selection logic reported
MultipleEntryPointsFound. The samelen() != 1branch handled both empty and ambiguous entry-point sets.This change separates those cases: an empty set now returns
NoEntryPointFound, a single entry point is selected, and multiple entry points continue to returnMultipleEntryPointsFound. Explicit entry-point selection keeps its existing behavior.Testing
cargo test -p wgpu-corecargo test -p wgpu-core --all-featurescargo clippy -p wgpu-core --tests -- -D warningscargo clippy --testscargo check -p wgpu-core --no-default-featurescargo fmt --all -- --checkcargo xtask changelogSquash or Rebase?
This is a single, logically scoped commit that is ready to rebase onto
trunk.Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.