chore(release): derive the repo slug from the git remote - #67
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release script now resolves the GitHub ChangesRelease repository resolution
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Propagated from
mantine-base-component:release.tsnow derives theowner/reposlug for the GitHub release from theoriginremote instead ofpackage/package.json→repository, falling back to the package.json field if no remote exists.Functional no-op for this repo — its
repositoryfield is already correct and resolves to the same slug (verified against the real remotes before propagating). The change matters for the template, where that field still points atgfazioli/mantine-ledby design, so every template release targeted the wrong repository and died withHTTP 422 … Release.tag_name already exists— which also abortedrelease:patchbeforedocs:deploycould run.Kept in sync so the template and the component repos don't drift.
Test plan
Summary by CodeRabbit