chore(security): patch vulnerable transitive dependencies - #66
Merged
Merged
Conversation
Advisory: 82 → 26 (yarn npm audit --recursive). Dev-only: the published package declares no dependencies, so none of these reached consumers. resolutions (copied from the template) lift the packages whose fix sits outside their parent's range — notably sharp (via next) and tar (via cacache/node-gyp). yarn up -R lifts the multi-major ones (minimatch, js-yaml, picomatch, brace-expansion, braces, glob, svgo), which resolutions cannot express: it matches a parent's exact descriptor, not a major range.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA top-level ChangesDependency Resolution
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Advisory: 82 → 26 (
yarn npm audit --recursive).Dev-only: the published package declares
dependencies: {}(only peers on Mantine/React), so none of these ever reached consumers — repo hygiene, propagated frommantine-base-component.Two mechanisms:
resolutionsfor packages whose fix sits outside the range their parent allows — notablysharp(vianext) andtar(viacacache/node-gyp, one critical).yarn up -Rfor the multi-major packages (minimatch,js-yaml,picomatch,brace-expansion,braces,glob,svgo), whose fixes are inside the parents' ranges.resolutionscannot express these: it matches a parent's exact descriptor (minimatch@npm:^3.0.4), not a major range, so"minimatch@^3"is silently inert.Whatever remains is dev-only with no published fix (legacy jest/jsdom chains,
ip).Test plan
Summary by CodeRabbit