Skip to content

chore(lint): adopt oxc-config-mantine for the oxlint ruleset - #65

Merged
gfazioli merged 1 commit into
masterfrom
chore/oxc-config-mantine
Jul 27, 2026
Merged

chore(lint): adopt oxc-config-mantine for the oxlint ruleset#65
gfazioli merged 1 commit into
masterfrom
chore/oxc-config-mantine

Conversation

@gfazioli

@gfazioli gfazioli commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary

Mantine 9.5 migrated its toolchain to oxc and published the shared config as oxc-config-mantine. This adopts the linter half of it: the hand-maintained oxlint.config.ts is replaced by a short oxlint.config.mjs that spreads the shared ruleset.

The formatter half is deliberately not adopted: that config orders imports via an importOrder key which oxfmt does not support (the key appears nowhere in oxfmt's dist; neither 0.55 nor 0.60 reacts to it, and upstream's own files show the declared order is not applied). Adopting it would silently drop the import sorting we get from sortImports.groups. .oxfmtrc.json is unchanged.

Two overrides on top of the shared ruleset:

  • curly: ['error', 'multi-line'] — upstream's curly: 'error' requires braces everywhere and conflicts with oxfmt collapsing single-statement bodies onto the condition line.
  • ignorePatterns adds docs/.next, which our docs sites have and upstream's list lacks.

Config-only change: no code files touched, no release.

Test plan

  • yarn test (syncpack + format + typecheck + lint + jest)
  • yarn build

Summary by CodeRabbit

  • Chores
    • Updated linting configuration for consistent formatting and rule behavior.
    • Excluded generated documentation and distribution output from lint checks.
    • Updated project scripts to use the new lint configuration.
    • Added the required configuration package for linting.

@gfazioli
gfazioli merged commit 90915b7 into master Jul 27, 2026
1 of 2 checks passed
@gfazioli
gfazioli deleted the chore/oxc-config-mantine branch July 27, 2026 17:06
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 343c20f2-8001-4073-963d-78c2e0a66e94

📥 Commits

Reviewing files that changed from the base of the PR and between e502933 and 565fb3b.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (3)
  • oxlint.config.mjs
  • oxlint.config.ts
  • package.json

📝 Walkthrough

Walkthrough

Oxlint now uses oxlint.config.mjs, which customizes the curly rule and ignores generated or distribution directories. The package lint script explicitly selects this configuration, and oxc-config-mantine is added as a development dependency.

Changes

Oxlint configuration migration

Layer / File(s) Summary
Configure Oxlint rules and ignores
oxlint.config.mjs
The configuration overrides curly to require braces for multi-line bodies and ignores generated documentation and distribution paths.
Wire the package command to the configuration
package.json
The oxlint script selects oxlint.config.mjs, and oxc-config-mantine is added to development dependencies.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/oxc-config-mantine

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant