chore(lint): adopt oxc-config-mantine for the oxlint ruleset - #65
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughOxlint now uses ChangesOxlint configuration migration
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mantine 9.5 migrated its toolchain to oxc and published the shared config as
oxc-config-mantine. This adopts the linter half of it: the hand-maintainedoxlint.config.tsis replaced by a shortoxlint.config.mjsthat spreads the shared ruleset.The formatter half is deliberately not adopted: that config orders imports via an
importOrderkey which oxfmt does not support (the key appears nowhere in oxfmt's dist; neither 0.55 nor 0.60 reacts to it, and upstream's own files show the declared order is not applied). Adopting it would silently drop the import sorting we get fromsortImports.groups..oxfmtrc.jsonis unchanged.Two overrides on top of the shared ruleset:
curly: ['error', 'multi-line']— upstream'scurly: 'error'requires braces everywhere and conflicts with oxfmt collapsing single-statement bodies onto the condition line.ignorePatternsaddsdocs/.next, which our docs sites have and upstream's list lacks.Config-only change: no code files touched, no release.
Test plan
Summary by CodeRabbit