feat(monitor): implement MMP system_powerdown (#88)#153
Conversation
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9f045c6c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "system_powerdown" => { | ||
| s.quit(); | ||
| json!({"return": {}}) |
There was a problem hiding this comment.
system_powerdown now sets quit_requested, but this path does not signal handle_connection() to return true, so run_tcp() does not break out like it does for quit and can remain blocked in listener.incoming() waiting for another connection. This means a client issuing system_powerdown may get a success response while the monitor thread keeps running until extra I/O occurs, which diverges from the shutdown behavior expected from the equivalent quit flow.
Useful? React with 👍 / 👎.
|
@SAY-5 Could you resolve conflicts? |
|
Looks like #124 landed and already implements system_powerdown plus the connection-loop fix, so this can be closed. Sorry for the noise. |
2 participants
Closes #88.
Adds the
system_powerdownMMP command. As noted in the issue, the existingMonitorService::quit()already does the right thing, so this mirrors thequitbranch and adds a regression test alongsidetest_mmp_quit.