Skip to content

docs(monitor): replace duplicate messages with meaningful information#100

Open
huhao345 wants to merge 2 commits into
gevico:mainfrom
huhao345:fix/remove-duplicate-messages
Open

docs(monitor): replace duplicate messages with meaningful information#100
huhao345 wants to merge 2 commits into
gevico:mainfrom
huhao345:fix/remove-duplicate-messages

Conversation

@huhao345
Copy link
Copy Markdown

Description

Replace repetitive placeholder messages in monitor modules with meaningful and descriptive information.

Files Changed

  • monitor/src/hmp.rs: Updated messages
  • monitor/src/mmp.rs: Updated messages

Type of Change

  • Documentation/Message improvement

@Lfan-ke
Copy link
Copy Markdown
Collaborator

Lfan-ke commented Apr 25, 2026

@codex Please help review this PR.

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@Lfan-ke
Copy link
Copy Markdown
Collaborator

Lfan-ke commented Apr 25, 2026

Code Standards Review

Commit: 9c6cb7edocs(monitor): replace duplicate messages with meaningful information

Conventional Commits format:docs(monitor): — correct
Headline length: ✅ 67 characters
Language: ✅ English


⚠️ Missing Signed-off-by:

The commit body is empty — no Signed-off-by: line is present. This is a hard requirement for all contributions to this repository (verified by CI).

Fix:

git commit --amend -s
git push --force-with-lease

This appends Signed-off-by: Your Name <email> automatically using your configured Git identity.

Reviewed against the RustSBI / machina contribution guidelines.

@zevorn
Copy link
Copy Markdown
Member

zevorn commented Apr 25, 2026

@codex Please review this PR

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@zevorn
Copy link
Copy Markdown
Member

zevorn commented Apr 25, 2026

please fix:

cargo fmt --all --check
Diff in /home/runner/work/machina/machina/monitor/src/mmp.rs:27:
                 }
             }
             Err(_) => {
-                if svc.lock().expect("monitor mutex poisoned").state.is_quit_requested() {
+                if svc
+                    .lock()
+                    .expect("monitor mutex poisoned")
+                    .state
+                    .is_quit_requested()
+                {
                     break;
                 }
             }
Diff in /home/runner/work/machina/machina/monitor/src/mmp.rs:43:
     let _ = writeln!(stream, "{}", GREETING);
     let _ = stream.flush();
 
-    let reader = BufReader::new(stream.try_clone().expect("monitor mutex poisoned"));
+    let reader =
+        BufReader::new(stream.try_clone().expect("monitor mutex poisoned"));
     let mut caps_done = false;
 
     for line in reader.lines() {
make: *** [Makefile:34: fmt-check] Error 1
Error: Process completed with exit code 2.

@Lfan-ke
Copy link
Copy Markdown
Collaborator

Lfan-ke commented Apr 25, 2026

Code Standards Review

Both commits are missing Signed-off-by::

  • 9c6cb7edocs(monitor): replace duplicate messages with meaningful information
  • 4c133a6docs(monitor): update message changes in mmp.rs

Fix both at once with an interactive rebase:

git rebase --exec 'git commit --amend --no-edit -s' HEAD~2
git push --force-with-lease

Reviewed against machina contribution guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants