Skip to content

chore: Manually upgrade gdUnit4 to v6.0.0 #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 6, 2025
Merged

chore: Manually upgrade gdUnit4 to v6.0.0 #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
64c6190
Bump gdUnit4 to v6.0.0
limbonaut Oct 6, 2025
19b134a
Bump json_assert for compatibility with new gdUnit
limbonaut Oct 6, 2025
fea5b02
Remove gdUnit4 patch
limbonaut Oct 6, 2025
9de3a71
Update CHANGELOG.md
limbonaut Oct 6, 2025
c4879f0
Remove left-over action code
limbonaut Oct 6, 2025
a2fe9e2
Fix `test_limit_throttling.gd` isolated test
limbonaut Oct 6, 2025
71c93c3
Remove CHANGELOG entry
limbonaut Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/actions/prepare-testing/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,6 @@ runs:
shell: bash
run: |
scons project/addons/gdUnit4
echo "Applying gdUnit4 patch"
cd modules/gdUnit4
# NOTE: Patching gdUnit4 as it errors out in Godot 4.5.
git apply ../gdunit4.patch

- name: Prepare project
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion modules/gdUnit4
Open in desktop
Submodule gdUnit4 updated 151 files
22 changes: 0 additions & 22 deletions modules/gdunit4.patch
View file
Open in desktop

This file was deleted.

14 changes: 7 additions & 7 deletions project/test/isolated/test_limit_throttling.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,14 @@ func _before_send(_ev: SentryEvent) -> SentryEvent:

## Only two errors should be logged within the assigned time window.
func test_throttling_limits() -> void:
var monitor := monitor_signals(self, false)
monitor_signals(self, false)

push_error("dummy-error")
push_error("dummy-error")
push_error("dummy-error")
await assert_signal(monitor).is_emitted("callback_processed")
await assert_signal(monitor).is_emitted("callback_processed")
await get_tree().create_timer(0.1).timeout

await assert_signal(self).is_emitted("callback_processed")
await get_tree().process_frame # allow all events to process
assert_int(_num_events).is_equal(2)

# Wait for throttling window to expire.
Expand All @@ -42,7 +43,6 @@ func test_throttling_limits() -> void:
push_error("dummy-error")
push_error("dummy-error")
push_error("dummy-error")
await assert_signal(monitor).is_emitted("callback_processed")
await assert_signal(monitor).is_emitted("callback_processed")
await get_tree().create_timer(0.1).timeout
await assert_signal(self).is_emitted("callback_processed")
await get_tree().process_frame # allow all events to process
assert_int(_num_events).is_equal(4)
2 changes: 1 addition & 1 deletion project/test/util/json_assert
Open in desktop
Submodule json_assert updated 1 files
+43 −0 JSONAssertImpl.gd