Skip to content

feat(android): Add screenshot strategy to session replay docs #15270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 29, 2025
Merged

feat(android): Add screenshot strategy to session replay docs #15270

merged 8 commits into from
Oct 29, 2025

Conversation

@romtsn
Copy link
Member

@romtsn romtsn commented Oct 21, 2025 •
edited
Loading

DESCRIBE YOUR PR

  • Add a new option screenshotStrategy which has been introduced in this PR and allows customers to specify a more reliable masking strategy.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline: Ideally next week
  • None: Not urgent, can wait up to 1 week+

@vercel
Copy link

vercel bot commented Oct 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 29, 2025 8:06am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Oct 29, 2025 8:06am

@codeowner-assignment codeowner-assignment bot requested a review from a team October 21, 2025 07:41
@romtsn romtsn marked this pull request as draft October 21, 2025 07:43
@codecov
Copy link

codecov bot commented Oct 21, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.98MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/V12gpItu_tMmP9xwwqdLx/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/V12gpItu_tMmP9xwwqdLx/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/thEFmICxE0hPqsZXbXGuI/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/thEFmICxE0hPqsZXbXGuI/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%

@romtsn romtsn marked this pull request as ready for review October 23, 2025 09:20
@romtsn romtsn mentioned this pull request Oct 23, 2025
Merged
10 tasks
antonis
antonis approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jas-kas
jas-kas approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@jas-kas jas-kas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy looks great!

romtsn
romtsn commented Oct 28, 2025
View reviewed changes
romtsn
romtsn commented Oct 28, 2025
View reviewed changes
romtsn
romtsn commented Oct 28, 2025
View reviewed changes
@codeowner-assignment codeowner-assignment bot requested a review from a team October 28, 2025 16:55
markushi
markushi approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙏

romtsn
romtsn commented Oct 29, 2025
View reviewed changes
romtsn
romtsn commented Oct 29, 2025
View reviewed changes
@codeowner-assignment codeowner-assignment bot requested a review from a team October 29, 2025 07:33
@romtsn romtsn merged commit 9a931fb into master Oct 29, 2025
13 checks passed
@romtsn romtsn deleted the rz/feat/android-screenshot-strategy branch October 29, 2025 08:16
@romtsn romtsn mentioned this pull request Oct 29, 2025
Merged
philipphofmann pushed a commit that referenced this pull request Oct 30, 2025
@romtsn @philipphofmann
feat(android): Add screenshot strategy to session replay docs (#15270)
b5a7c79 
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->

## DESCRIBE YOUR PR
- Add a new option `screenshotStrategy` which has been introduced in
this [PR](getsentry/sentry-java#4777) and allows
customers to specify a more reliable masking strategy.

## IS YOUR CHANGE URGENT?  

Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [x] Other deadline: Ideally next week
- [ ] None: Not urgent, can wait up to 1 week+
romtsn added a commit that referenced this pull request Nov 4, 2025
@romtsn
feat(replay): Add screenshotStrategy option for React Native (#15334)
6df5e4d 
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->

## DESCRIBE YOUR PR
- Merge after getsentry/sentry-react-native#5301
- Similar to #15270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonis antonis antonis approved these changes

@markushi markushi markushi approved these changes

@jas-kas jas-kas jas-kas approved these changes

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@romtsn @antonis @markushi @jas-kas