-
-
Notifications
You must be signed in to change notification settings - Fork 278
Sentry Supabase Integration #2913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2913 +/- ##
==========================================
- Coverage 88.31% 88.19% -0.13%
==========================================
Files 291 291
Lines 9957 9957
==========================================
- Hits 8794 8782 -12
- Misses 1163 1175 +12 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2b5e090 | 437.21 ms | 467.14 ms | 29.93 ms |
| 8541716 | 437.14 ms | 443.65 ms | 6.51 ms |
| 32914d8 | 461.96 ms | 495.47 ms | 33.51 ms |
| ec78888 | 457.94 ms | 519.96 ms | 62.02 ms |
| 8825ed8 | 447.65 ms | 456.90 ms | 9.25 ms |
| d3fb366 | 391.49 ms | 385.85 ms | -5.64 ms |
| c8596a6 | 474.00 ms | 492.96 ms | 18.96 ms |
| 7cfee3b | 498.78 ms | 516.98 ms | 18.20 ms |
| 9b99523 | 456.91 ms | 490.55 ms | 33.64 ms |
| 0fb45d0 | 482.79 ms | 554.02 ms | 71.23 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2b5e090 | 13.93 MiB | 15.06 MiB | 1.13 MiB |
| 8541716 | 13.93 MiB | 15.00 MiB | 1.06 MiB |
| 32914d8 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| ec78888 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 8825ed8 | 13.93 MiB | 14.93 MiB | 1.00 MiB |
| d3fb366 | 13.93 MiB | 15.06 MiB | 1.13 MiB |
| c8596a6 | 6.54 MiB | 7.53 MiB | 1015.27 KiB |
| 7cfee3b | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| 9b99523 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 0fb45d0 | 6.54 MiB | 7.70 MiB | 1.17 MiB |
Previous results on branch: feat/supabase
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5e3ca91 | 451.24 ms | 496.74 ms | 45.50 ms |
| 30c089b | 471.71 ms | 522.65 ms | 50.94 ms |
| 0ab2edd | 459.85 ms | 506.63 ms | 46.77 ms |
| 2db18e6 | 470.42 ms | 473.86 ms | 3.43 ms |
| 2c3bf29 | 437.27 ms | 454.44 ms | 17.17 ms |
| de422e0 | 364.02 ms | 362.76 ms | -1.27 ms |
| 1476f86 | 477.10 ms | 480.87 ms | 3.77 ms |
| e4d1bf6 | 499.64 ms | 528.47 ms | 28.82 ms |
| f8ec07b | 452.65 ms | 537.85 ms | 85.21 ms |
| 22c24e6 | 483.94 ms | 485.42 ms | 1.48 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5e3ca91 | 6.44 MiB | 7.44 MiB | 1017.53 KiB |
| 30c089b | 6.44 MiB | 7.43 MiB | 1010.46 KiB |
| 0ab2edd | 6.54 MiB | 7.53 MiB | 1016.33 KiB |
| 2db18e6 | 13.93 MiB | 14.93 MiB | 1.00 MiB |
| 2c3bf29 | 13.93 MiB | 15.06 MiB | 1.13 MiB |
| de422e0 | 13.93 MiB | 15.06 MiB | 1.13 MiB |
| 1476f86 | 13.93 MiB | 14.93 MiB | 1.00 MiB |
| e4d1bf6 | 6.44 MiB | 7.44 MiB | 1017.53 KiB |
| f8ec07b | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| 22c24e6 | 13.93 MiB | 15.06 MiB | 1.13 MiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e2d675d | 1238.48 ms | 1242.76 ms | 4.28 ms |
| 6b69699 | 1254.80 ms | 1273.31 ms | 18.52 ms |
| 5b9a0da | 1249.69 ms | 1250.71 ms | 1.03 ms |
| 7cfbbd6 | 1270.63 ms | 1285.36 ms | 14.72 ms |
| a69a51f | 1231.73 ms | 1233.15 ms | 1.42 ms |
| ad121c0 | 1275.04 ms | 1280.59 ms | 5.55 ms |
| 6ad8fc4 | 1263.70 ms | 1266.06 ms | 2.36 ms |
| 393f8ec | 1256.45 ms | 1259.60 ms | 3.16 ms |
| d0aa4b6 | 1268.23 ms | 1268.39 ms | 0.15 ms |
| 819c1e7 | 1250.59 ms | 1249.08 ms | -1.51 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e2d675d | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 6b69699 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 5b9a0da | 5.53 MiB | 5.96 MiB | 444.32 KiB |
| 7cfbbd6 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| a69a51f | 5.53 MiB | 6.01 MiB | 487.38 KiB |
| ad121c0 | 5.53 MiB | 6.01 MiB | 488.11 KiB |
| 6ad8fc4 | 5.53 MiB | 6.01 MiB | 487.65 KiB |
| 393f8ec | 5.53 MiB | 6.01 MiB | 488.10 KiB |
| d0aa4b6 | 5.53 MiB | 6.02 MiB | 502.04 KiB |
| 819c1e7 | 5.53 MiB | 6.00 MiB | 479.96 KiB |
Previous results on branch: feat/supabase
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 34b0923 | 1269.29 ms | 1275.88 ms | 6.59 ms |
| 22c24e6 | 1254.75 ms | 1265.22 ms | 10.47 ms |
| 5454931 | 1266.92 ms | 1270.20 ms | 3.29 ms |
| b0f288d | 1261.51 ms | 1264.02 ms | 2.51 ms |
| 0a08454 | 1265.15 ms | 1283.18 ms | 18.04 ms |
| 2c3bf29 | 1248.09 ms | 1259.79 ms | 11.70 ms |
| f8ec07b | 1259.06 ms | 1273.22 ms | 14.16 ms |
| de422e0 | 1245.98 ms | 1249.29 ms | 3.31 ms |
| e4d1bf6 | 1249.16 ms | 1267.12 ms | 17.96 ms |
| 5e3ca91 | 1263.90 ms | 1277.43 ms | 13.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 34b0923 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
| 22c24e6 | 5.53 MiB | 6.00 MiB | 485.11 KiB |
| 5454931 | 5.53 MiB | 6.00 MiB | 479.95 KiB |
| b0f288d | 5.53 MiB | 6.00 MiB | 479.95 KiB |
| 0a08454 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
| 2c3bf29 | 5.53 MiB | 6.01 MiB | 488.12 KiB |
| f8ec07b | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| de422e0 | 5.53 MiB | 6.01 MiB | 488.14 KiB |
| e4d1bf6 | 8.43 MiB | 10.00 MiB | 1.56 MiB |
| 5e3ca91 | 8.43 MiB | 10.00 MiB | 1.56 MiB |
buenaflor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! only a few comments left
| - name: supabase | ||
| working-directory: ./packages/supabase | ||
| run: lakos . -i "{test/**,example/**}" | dot -Tsvg -o class-diagram.svg | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
honestly I keep forgetting this diagram exists 😓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, we could think about removing this, no? My hunch is nobody uses it and it's outdated anyway. We could leave it as a dev option so we can generate it locally to get an overview, but remove the checked in files. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea imo we can remove it in another PR
|
cloudflare has an outage so lots of tests are failing now that depend on external downloads |
|
@buenaflor Last week I created a sample project with Flutter + Subase as an evaluation. I wan't to try this out before we merge. |
|
sounds good, looks good to me now let me know if you thinks its ready |
|
@buenaflor Ok, looking good with the sample app. The error client is being called and breadcrumbs created.
Only thing i saw that the hub does not have a span, so we can't create one. Dunno if this is supposed to be like that? We have the same logic in other integrations.
|
do you have a running transaction with |
|
We discussed that this works now |


📜 Description
Supabase instrumentation for database operations (no auth instrumentation)
💡 Motivation and Context
Closes #2727
💚 How did you test it?
Unit tests.
📝 Checklist
sendDefaultPiiis enabled