Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Nov 28, 2025

Renames the Carthage validation project which uses xcframeworks to just XCFramework Validation project

Cleanups some script that wont be used anymore too.

Follows #6926 in removing Carthage references.

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Nov 28, 2025
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.036%. Comparing base (fad87d5) to head (f60d520).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #6931   +/-   ##
=========================================
  Coverage   85.036%   85.036%           
=========================================
  Files          453       453           
  Lines        27660     27660           
  Branches     12146     12147    +1     
=========================================
  Hits         23521     23521           
+ Misses        4095      4092    -3     
- Partials        44        47    +3     

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fad87d5...f60d520. Read the comment docs.

@itaybre itaybre marked this pull request as ready for review November 28, 2025 19:42
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1216.54 ms 1244.34 ms 27.80 ms
Size 24.14 KiB 1.01 MiB 1013.56 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ca91f42 1223.69 ms 1249.14 ms 25.45 ms
8d944ac 1236.92 ms 1254.91 ms 18.00 ms
762a701 1219.96 ms 1249.92 ms 29.96 ms
5fcb6a1 1198.86 ms 1226.89 ms 28.03 ms
e70670c 1223.47 ms 1238.67 ms 15.20 ms
331dad6 1210.40 ms 1242.06 ms 31.67 ms
6b01cf3 1197.98 ms 1219.88 ms 21.90 ms
102cf89 1218.31 ms 1239.78 ms 21.47 ms
daeb716 1215.41 ms 1246.52 ms 31.11 ms
1b899b8 1225.50 ms 1255.42 ms 29.92 ms

App size

Revision Plain With Sentry Diff
ca91f42 23.75 KiB 913.63 KiB 889.88 KiB
8d944ac 23.75 KiB 919.69 KiB 895.94 KiB
762a701 23.75 KiB 1022.66 KiB 998.91 KiB
5fcb6a1 24.14 KiB 1.01 MiB 1014.60 KiB
e70670c 23.75 KiB 975.19 KiB 951.45 KiB
331dad6 23.75 KiB 928.12 KiB 904.37 KiB
6b01cf3 23.75 KiB 1.00 MiB 1005.08 KiB
102cf89 23.74 KiB 891.02 KiB 867.27 KiB
daeb716 23.75 KiB 928.16 KiB 904.41 KiB
1b899b8 23.75 KiB 1.00 MiB 1005.08 KiB

Previous results on branch: itay/rename_xcframework_validation_project

Startup times

Revision Plain With Sentry Diff
ae248b0 1202.06 ms 1224.84 ms 22.78 ms
a62046d 1222.37 ms 1246.24 ms 23.88 ms

App size

Revision Plain With Sentry Diff
ae248b0 24.14 KiB 1.01 MiB 1013.15 KiB
a62046d 24.14 KiB 1.01 MiB 1015.24 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itaybre itaybre merged commit 1b15a2a into main Dec 1, 2025
248 checks passed
@itaybre itaybre deleted the itay/rename_xcframework_validation_project branch December 1, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants