-
-
Notifications
You must be signed in to change notification settings - Fork 372
chore: Rename CARTHAGE macro to XCODE
#6929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6929 +/- ##
=============================================
+ Coverage 84.913% 85.061% +0.148%
=============================================
Files 453 453
Lines 27628 27634 +6
Branches 12133 12141 +8
=============================================
+ Hits 23460 23506 +46
+ Misses 4123 4080 -43
- Partials 45 48 +3
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0ee162c | 1226.90 ms | 1261.72 ms | 34.83 ms |
| 7f26f16 | 1220.62 ms | 1255.04 ms | 34.42 ms |
| 5290541 | 1216.38 ms | 1249.56 ms | 33.18 ms |
| 319fb1e | 1219.48 ms | 1242.69 ms | 23.21 ms |
| 0f410ad | 1193.34 ms | 1255.49 ms | 62.15 ms |
| b6f8eb3 | 1217.94 ms | 1246.57 ms | 28.63 ms |
| e8f9a1d | 1229.02 ms | 1264.17 ms | 35.15 ms |
| 37238de | 1236.00 ms | 1267.80 ms | 31.80 ms |
| 0ecea77 | 1191.47 ms | 1216.12 ms | 24.65 ms |
| 1655116 | 1220.72 ms | 1260.58 ms | 39.85 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0ee162c | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| 7f26f16 | 23.75 KiB | 1.02 MiB | 1016.66 KiB |
| 5290541 | 24.14 KiB | 1.01 MiB | 1015.38 KiB |
| 319fb1e | 23.75 KiB | 1019.18 KiB | 995.43 KiB |
| 0f410ad | 24.14 KiB | 1.01 MiB | 1014.82 KiB |
| b6f8eb3 | 23.75 KiB | 988.70 KiB | 964.95 KiB |
| e8f9a1d | 23.75 KiB | 969.78 KiB | 946.04 KiB |
| 37238de | 23.75 KiB | 963.18 KiB | 939.43 KiB |
| 0ecea77 | 24.15 KiB | 1.01 MiB | 1014.90 KiB |
| 1655116 | 23.75 KiB | 1023.84 KiB | 1000.10 KiB |
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In sync with #6926, since we no longer plan to use Carthage, I am renaming the precompiler flags to
XCODE, to avoid confussions.