Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Nov 28, 2025

In sync with #6926, since we no longer plan to use Carthage, I am renaming the precompiler flags to XCODE, to avoid confussions.

@itaybre itaybre marked this pull request as ready for review November 28, 2025 18:39
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.061%. Comparing base (532f33c) to head (2147614).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Swift/Helper/SentrySdkPackage.swift 0.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6929       +/-   ##
=============================================
+ Coverage   84.913%   85.061%   +0.148%     
=============================================
  Files          453       453               
  Lines        27628     27634        +6     
  Branches     12133     12141        +8     
=============================================
+ Hits         23460     23506       +46     
+ Misses        4123      4080       -43     
- Partials        45        48        +3     
Files with missing lines Coverage Δ
...entrySwiftUI/Preview/SentryReplayMaskPreview.swift 0.000% <ø> (ø)
...wiftUI/Preview/SentryReplayMaskPreviewUIView.swift 0.000% <ø> (ø)
Sources/SentrySwiftUI/SentryReplayView.swift 33.333% <ø> (ø)
Sources/SentrySwiftUI/SentryTracedView.swift 72.222% <ø> (ø)
Sources/Swift/Helper/SentrySdkPackage.swift 90.476% <0.000%> (-4.979%) ⬇️

... and 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 532f33c...2147614. Read the comment docs.

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Nov 28, 2025
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.26 ms 1252.87 ms 27.61 ms
Size 24.14 KiB 1.01 MiB 1015.20 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0ee162c 1226.90 ms 1261.72 ms 34.83 ms
7f26f16 1220.62 ms 1255.04 ms 34.42 ms
5290541 1216.38 ms 1249.56 ms 33.18 ms
319fb1e 1219.48 ms 1242.69 ms 23.21 ms
0f410ad 1193.34 ms 1255.49 ms 62.15 ms
b6f8eb3 1217.94 ms 1246.57 ms 28.63 ms
e8f9a1d 1229.02 ms 1264.17 ms 35.15 ms
37238de 1236.00 ms 1267.80 ms 31.80 ms
0ecea77 1191.47 ms 1216.12 ms 24.65 ms
1655116 1220.72 ms 1260.58 ms 39.85 ms

App size

Revision Plain With Sentry Diff
0ee162c 23.75 KiB 933.33 KiB 909.58 KiB
7f26f16 23.75 KiB 1.02 MiB 1016.66 KiB
5290541 24.14 KiB 1.01 MiB 1015.38 KiB
319fb1e 23.75 KiB 1019.18 KiB 995.43 KiB
0f410ad 24.14 KiB 1.01 MiB 1014.82 KiB
b6f8eb3 23.75 KiB 988.70 KiB 964.95 KiB
e8f9a1d 23.75 KiB 969.78 KiB 946.04 KiB
37238de 23.75 KiB 963.18 KiB 939.43 KiB
0ecea77 24.15 KiB 1.01 MiB 1014.90 KiB
1655116 23.75 KiB 1023.84 KiB 1000.10 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itaybre itaybre merged commit d8efbb3 into main Dec 1, 2025
230 of 242 checks passed
@itaybre itaybre deleted the itay/rename_carthage_precompiler_flag branch December 1, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants