feat(eap): Add support for native scalar arrays #5394
Draft
+50
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
reviewed
Nov 19, 2025
| /// | ||
| /// The respective value must be of type [`Value::String`]. | ||
| String, | ||
| /// A string type. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// A string type. | |
| /// An array type. |
| /// | ||
| /// The respective value must be of type [`Value::Bool`]. | ||
| Boolean, | ||
| /// A integer type. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// A integer type. | |
| /// An integer type. |
|
|
||
| #[derive(Debug, Clone, PartialEq, Eq)] | ||
| pub enum AttributeType { | ||
| /// A boolean type. |
Contributor
There was a problem hiding this comment.
I would remove the "type" from all of these.
Suggested change
| /// A boolean type. | |
| /// A boolean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a WIP to show what needs to be changed.
We can split this PR into multiple parts, one for each type:
Need to expand existing tests for all of these.