WIP: Span attachment #5363
Draft
WIP: Span attachment #5363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
reviewed
Nov 11, 2025
tobias-wilfert
commented
Nov 12, 2025
jjbayer
reviewed
Nov 18, 2025
jjbayer
reviewed
Nov 24, 2025
Member
jjbayer
left a comment
jjbayer
left a comment
There was a problem hiding this comment.
I left a bunch of comments but overall this looks good! Great tests!
Co-authored-by: Joris Bayer <[email protected]>
jjbayer
reviewed
Nov 25, 2025
jjbayer
reviewed
Nov 25, 2025
tobias-wilfert
commented
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the initial logic for span-attachments to the span processor.
Follow-ups:
Fixes INGEST-613