feat(ourlog): Add vercel log drain transform #5209
Open
+719
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
reviewed
Oct 3, 2025
Comment on lines
142
to
150
| /// Span identifier for distributed tracing. | ||
| #[serde(rename = "spanId")] | ||
| pub span_id: Option<String>, | ||
| /// Trace identifier for distributed tracing. | ||
| #[serde(rename = "trace.id")] | ||
| pub trace_dot_id: Option<String>, | ||
| /// Span identifier for distributed tracing. | ||
| #[serde(rename = "span.id")] | ||
| pub span_dot_id: Option<String>, |
There was a problem hiding this comment.
You can use serde alias to prevent having multiple fields here.
There was a problem hiding this comment.
Unfortunately this can't work because the schema allows traceId and trace.id to be sent together, and we still want serialization to work here. Is there a way we can get around that with serde?
k-fish
reviewed
Oct 3, 2025
| add_attribute!(HTTP_RESPONSE_STATUS_CODE, code); | ||
| } | ||
|
|
||
| add_optional_attribute!(HTTP_RESPONSE_STATUS_CODE, status_code); |
There was a problem hiding this comment.
You're already adding this above, I think we should probably restate this as add_optional_attribute!('vercel.status_code',) to include information about -1 where it doesn't conflict with our status code conventions
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/getsentry/issue/LOGS-389/add-vercel-log-drain-endpoint-to-relay
This PR updates the
relay-ourlogscreate to add aVercelLogstruct and avercel_log_to_sentry_logtransform method.vercel_log_to_sentry_logturns an incomingVercelLogjson payload structure into an instance of Sentry'sOurLog.I haven't hooked up the
vercel_log_to_sentry_logfunction to an endpoint and the rest of the processing pipeline on purpose, I want to take our time to make sure we are all good with the transform taking place.Many of these attributes are new, I've opened a PR in the conventions repo to document them accordingly: getsentry/sentry-conventions#163. See this notion doc for details about the schema and the transform: https://www.notion.so/sentry/Vercel-Log-Drain-2808b10e4b5d808c95f3ebcfe2b8828a. The attribute keys here align in naming as per https://vercel.com/docs/drains/reference/logs.
After this PR merges in, I'll work on exposing this in a new integrations endpoint, gated behind the feature flag introduced in #5208