ref(metric-stats): Purges metric stats from the codebase #5097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/rm-metric-stats
branch
from
b4c3b71 to
9e1f1a4
Compare
loewenheim
reviewed
Aug 29, 2025
loewenheim
approved these changes
Aug 29, 2025
Dav1dde
added a commit
to getsentry/sentry
that referenced
this pull request
Aug 29, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
constantinius
pushed a commit
to getsentry/sentry
that referenced
this pull request
Sep 1, 2025
andrewshie-sentry
pushed a commit
to getsentry/sentry
that referenced
this pull request
Sep 9, 2025
vgrozdanic
added a commit
to getsentry/sentry
that referenced
this pull request
Sep 11, 2025
In getsentry/relay#5097 we have removed the `metric_stats` completely from the relay, but it is still generated as a part of global config in Sentry. This is now preventing us to bump `sentry-relay` package (#99205), because the tests are failing. Clean up plan: - stop checking for `metric_stats` in test - bump `sentry-relay` dependency - remove `metric_stats` from sentry codebase Code used to find the diff: ```py for key, value in normalized.items(): if value != config[key]: import difflib import pprint config_str = pprint.pformat(config[key], width=120, sort_dicts=True) value_str = pprint.pformat(value, width=120, sort_dicts=True) diff = "\n".join( difflib.unified_diff( config_str.splitlines(), value_str.splitlines(), fromfile="config", tofile="normalized", lineterm="", ) ) print(f"Difference for key '{key}':\n{diff}") raise Exception(f"Value for key {key} is not equal to other value") ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You were a good feature, you were a useful feature. Unfortunately you never got to shine (rip DDM).