experiments: prefer the authoritative culledAt stamp over /tracks inference

[reflog]

What

Companion to getlantern/lantern-cloud#3126, which closes the bookkeeping gap #79 worked around: CullWorst now stamps culled_at / culled_by_experiment_id on the culled track's experiment row (with a migration backfilling the existing husks) and carries both through the promoted-comparison endpoint.

The promoted-vs-original cards now treat a promotion as culled when either:

• culledAt is set (authoritative; survives a /tracks fetch failure), or
• the promoted track is absent from the live-tracks list (the experiments: badge/hide culled promotions on promoted-vs-original cards; hide aborted by default #79/experiments: detect culled promotions by absence from /tracks, not its disabled field #80 heuristic — still needed for promoted tracks disabled outside a cull, which nothing stamps).

When the stamp attributes the culling promotion, the badge upgrades from culled to culled by #N with the cull date in the tooltip.

Notes

• Rows predating the API deploy keep working via the heuristic; the migration backfill stamps all existing husks at deploy time, so the union converges to the stamp.
• npm run build clean; npm run lint identical to main (17 pre-existing problems, none introduced).

Summary by CodeRabbit

• New Features

  • Promoted traffic cards now identify tracks that have been removed from active traffic.
  • When available, cards show the promotion responsible for the removal and the date it occurred.
  • Track status detection remains reliable even when live activity information is temporarily unavailable.

• Bug Fixes

  • Improved promoted traffic filtering, counts, visibility, and status handling to accurately reflect current track activity.

[cloudflare-workers-and-pages]

Deploying lantern-dashboard with    Cloudflare Pages

Latest commit:	2c2ec18
Status:	✅  Deploy successful!
Preview URL:	https://c29d556a.lantern-dashboard.pages.dev
Branch Preview URL:	https://reflog-culled-at-field.lantern-dashboard.pages.dev

View logs

[coderabbitai]

Warning

Review limit reached

@reflog, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a4dc3c8c-8cf8-4bfe-9dd8-6fedc33579f5

📥 Commits

Reviewing files that changed from the base of the PR and between a50ff51 and 2c2ec18.

📒 Files selected for processing (1)

• src/components/ExperimentsOverview.tsx

📝 Walkthrough

Walkthrough

The promoted comparison API now exposes culling metadata. The experiments overview uses that metadata and live-track presence to detect culled tracks, update counts and filters, and show culling details on promotion traffic cards.

Changes

Promoted track culling

Layer / File(s)	Summary
Culling metadata contract src/api/client.ts	PromotedComparisonPoint now includes optional culledAt and culledByExperimentId fields.
Overview culling detection and display src/components/ExperimentsOverview.tsx	Culled detection uses culling metadata or live-track absence. Counts, filtering, card wiring, and culled labels use the complete promotion point.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• getlantern/lantern-dashboard#70: Introduces the PromotedComparisonPoint usage extended by this change.
• getlantern/lantern-dashboard#79: Adds related promoted culling detection and card labeling logic.
• getlantern/lantern-dashboard#77: Surfaces related promoted-experiment lifecycle metadata in the same API and overview files.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: using the authoritative culledAt value before /tracks inference.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch reflog/culled-at-field

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Updates the Experiments “Promoted vs original” UI to prefer the new server-provided cull stamp (culledAt / culledByExperimentId) when deciding whether a promoted track has been culled, while retaining the existing /tracks-presence heuristic as a fallback for non-cull disables.

Changes:

• Extend PromotedComparisonPoint with culledAt and culledByExperimentId fields from the promoted-comparison endpoint.
• Update culled detection to treat a promotion as culled when culledAt is present, otherwise fall back to “missing from live tracks”.
• Enhance the culled badge/tooltip to attribute “culled by #N” when culledByExperimentId is available.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/components/ExperimentsOverview.tsx	Prefer authoritative culledAt/culledByExperimentId for culled detection and improve culled badge/tooltip messaging, with /tracks fallback retained.
src/api/client.ts	Add typed fields for the new cull stamp data on promoted-comparison points.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.