Conversation
Collaborator
Author
|
cc/ @ahoy-jon one of the modules we discussed about |
fwbrasil
commented
Mar 30, 2026
| infix def ++(other: Dict[K, V]): Dict[K, V] = concat(other) | ||
|
|
||
| /** Applies the given function to each key-value pair in this Dict. */ | ||
| inline def foreach(inline fn: (K, V) => Unit): Unit = |
Collaborator
Author
There was a problem hiding this comment.
I had compilation crashes. I'll follow up separately on this.
fwbrasil
force-pushed
the
kyo-flow-pr
branch
5 times, most recently
from
7a9676e to
7767005
Compare
Collaborator
|
@fwbrasil thanks a lot, reviewing! |
Collaborator
|
So far it's great, I am checking additional stuffs on my machine |
Collaborator
Author
|
cool! I've made some fixes and cleanups |
Collaborator
|
still at it, so far it's good. Even tested cycle in definitions, it behaves as it should (not easy to express, clear stackoverflow at the right place). Will do some expressivity tests tomorrow! |
…ations Signal can drop notifications if the consumer subscribes after the producer fires. Replace with Channel[Unit](1) which buffers one notification so it can never be missed. Also increase SignalTest.streamChanges sleeps from 2ms to 30ms to avoid flakiness on loaded CI runners.
ahoy-jon
approved these changes
Apr 9, 2026
channel.poll before Async.race was consuming notifications that arrived after tryOnce read the store, causing channel.take to block indefinitely. Drop the poll so notifications flow directly to the race's channel.take.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new module uses the same technique as
kyo-httpusingRecords to track fields. Please see the README for more info. A major omission in this initial version is no persistentFlowStore. I want to have a good solution for relational db support first.The new module is build on top of
kyo-httpand supports JVM, JS, and Native.