Skip to content

fixing performance bug in PHP implementation #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: php
Choose a base branch
from
Open

fixing performance bug in PHP implementation #69

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c642588
fixing performance bug (see #64) in PHP implementation
getify Dec 15, 2021
8145afa
tweaking to just copy less string, which should give better perf
getify Dec 15, 2021
46898e2
per #64, more performance tweaks
getify Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions minify.json.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php

/*! JSON.minify()
v0.1 (c) Kyle Simpson
v3.0 (c) Kyle Simpson
MIT License
*/

Expand All @@ -10,24 +10,25 @@ function json_minify($json) {
$in_string = false;
$in_multiline_comment = false;
$in_singleline_comment = false;
$tmp; $tmp2; $new_str = array(); $ns = 0; $from = 0; $lc; $rc; $lastIndex = 0;
$tmp; $tmp2; $new_str = array(); $ns = 0; $from = 0; $prevFrom = 0; $lc; $rc; $lastIndex = 0;

while (preg_match($tokenizer,$json,$tmp,PREG_OFFSET_CAPTURE,$lastIndex)) {
$tmp = $tmp[0];
$lastIndex = $tmp[1] + strlen($tmp[0]);
$lc = substr($json,0,$lastIndex - strlen($tmp[0]));
$prevFrom = $from;
$lc = substr($json,$prevFrom,$lastIndex - strlen($tmp[0]));
$rc = substr($json,$lastIndex);
if (!$in_multiline_comment && !$in_singleline_comment) {
$tmp2 = substr($lc,$from);
if (!$in_string) {
$tmp2 = preg_replace("/(\n|\r|\s)*/","",$tmp2);
$tmp2 = preg_replace("/(\n|\r|\s)+/","",$tmp2);
}
$new_str[] = $tmp2;
}
$from = $lastIndex;

if ($tmp[0] == "\"" && !$in_multiline_comment && !$in_singleline_comment) {
preg_match("/(\\\\)*$/",$lc,$tmp2);
preg_match("/(\\\\)+$/",$lc,$tmp2);
if (!$in_string || !$tmp2 || (strlen($tmp2[0]) % 2) == 0) { // start of string with ", or unescaped " character found to end string
$in_string = !$in_string;
}
Expand All @@ -54,4 +55,4 @@ function json_minify($json) {
return implode("",$new_str);
}

?>
?>