fix(product-editor): whitelist the spmv_search field variant - #3330
fix(product-editor): whitelist the spmv_search field variant#3330MdAsifHossainNadim wants to merge 1 commit into
Conversation
Unknown variants fall back to a plain text input, so without this entry the SPMV panel's field would render as a stray "Search Product" text box and log a debug notice. Follows the existing location_map precedent for a Pro-module-owned variant. Refs getdokan/dokan-pro#5930 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 15 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
All Submissions:
Changes proposed in this Pull Request:
One array entry:
'spmv_search'added toFormSchema::$supported_variants.getFieldConfigFrom()falls back todefaultHandlerfor an unknown variant, which renders a plain text input — so without this entry the SPMV panel's field would appear in the new product editor as a stray "Search Product" text box, on top of the_doing_it_wrongdebug notice.Deliberately an array entry rather than a new filter:
$supported_variantsalready hardcodeslocation_mapfor the geolocation module, so this follows the house precedent. Adding a public filter would be permanent API surface introduced only to suppress a debug notice.Related Pull Request(s)
Closes
How to test the changes in this Pull Request:
With the Pro PR applied and the SPMV module enabled, open Vendor Dashboard → Products → Add New. Without this entry the SPMV card renders a bare text input; with it the registered React variant renders. PHPCS clean; no build required.
Changelog entry
Fix — register the
spmv_searchproduct editor field variant so the Single Product Multi Vendor search panel renders correctly.🤖 Generated with Claude Code