Skip to content

fix(product-editor): whitelist the spmv_search field variant - #3330

Open
MdAsifHossainNadim wants to merge 1 commit into
developfrom
fix/5930-spmv-search-new-product-editor
Open

fix(product-editor): whitelist the spmv_search field variant#3330
MdAsifHossainNadim wants to merge 1 commit into
developfrom
fix/5930-spmv-search-new-product-editor

Conversation

@MdAsifHossainNadim

@MdAsifHossainNadim MdAsifHossainNadim commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

All Submissions:

Changes proposed in this Pull Request:

One array entry: 'spmv_search' added to FormSchema::$supported_variants.

getFieldConfigFrom() falls back to defaultHandler for an unknown variant, which renders a plain text input — so without this entry the SPMV panel's field would appear in the new product editor as a stray "Search Product" text box, on top of the _doing_it_wrong debug notice.

Deliberately an array entry rather than a new filter: $supported_variants already hardcodes location_map for the geolocation module, so this follows the house precedent. Adding a public filter would be permanent API surface introduced only to suppress a debug notice.

Related Pull Request(s)

  • getdokan/dokan-pro#5952 — the actual SPMV port. That PR is functional without this one; this only prevents the stray text input and the debug notice.

Closes

How to test the changes in this Pull Request:

With the Pro PR applied and the SPMV module enabled, open Vendor Dashboard → Products → Add New. Without this entry the SPMV card renders a bare text input; with it the registered React variant renders. PHPCS clean; no build required.

Changelog entry

Fix — register the spmv_search product editor field variant so the Single Product Multi Vendor search panel renders correctly.

🤖 Generated with Claude Code

Unknown variants fall back to a plain text input, so without this entry
the SPMV panel's field would render as a stray "Search Product" text box
and log a debug notice. Follows the existing location_map precedent for
a Pro-module-owned variant.

Refs getdokan/dokan-pro#5930

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@MdAsifHossainNadim, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 15 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4e813e0f-9009-4bca-9139-c3d12bae841d

📥 Commits

Reviewing files that changed from the base of the PR and between db92d4b and 42e5749.

📒 Files selected for processing (1)
  • includes/ProductEditor/FormSchema.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/5930-spmv-search-new-product-editor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MdAsifHossainNadim MdAsifHossainNadim self-assigned this Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant