Skip to content

Fix symbolic expression generators - #129

Merged
gerlero merged 1 commit into
mainfrom
symbolic
Nov 24, 2025
Merged

Fix symbolic expression generators#129
gerlero merged 1 commit into
mainfrom
symbolic

Conversation

@gerlero

@gerlero gerlero commented Nov 24, 2025

Copy link
Copy Markdown
Owner

No description provided.

@codecov

codecov Bot commented Nov 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.13%. Comparing base (54b1903) to head (19f420b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   72.13%   72.13%           
=======================================
  Files           6        6           
  Lines         994      994           
=======================================
  Hits          717      717           
  Misses        277      277           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the symbolic expression generator where strict=True was incorrectly used when zipping an infinite generator with a finite range.

  • The _derivative_names() function is an infinite generator, which would cause a ValueError when zipped with range(3) using strict=True
  • Changed strict=False on line 73 to allow the zip to stop at the shortest iterable (3 elements)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment thread symbolic/generate.py
@gerlero
gerlero merged commit 8815c8f into main Nov 24, 2025
22 checks passed
@gerlero
gerlero deleted the symbolic branch November 24, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants