Add support for "show" option with packet pixel format (RGB24, BGR24…)#33
Open
Karry wants to merge 1 commit intogeorgmartius:masterfrom
Open
Add support for "show" option with packet pixel format (RGB24, BGR24…)#33Karry wants to merge 1 commit intogeorgmartius:masterfrom
Karry wants to merge 1 commit intogeorgmartius:masterfrom
Conversation
Contributor
Author
|
Hi @georgmartius , are you interested for this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes current draw* methods independent on pixel format. Pixel format is handled by two new methods - drawHLine and drawVLine that support all supported pixel formats.
Color type was changed to uint32_t. draw[HV]Line methods draw with RGB color for packet pixel formats but just for Y component of planar pixel format...
note: this code was tested with RGB24 and YUV 4:2:2 only!