chore(nbs): drop ubcpdk, use generic PDK - #234
Merged
Merged
Conversation
Intent / rationale - Remove the UBC PDK dependency from MEEP example notebooks and the docs CI workflow; notebooks now load pcells from the gdsfactory generic PDK (gpdk) or the gdsfactoryplus active PDK. Changes introduced - meep_ybranch/meep_crossing/meep_dc/meep_ring_coupler: load pcells via gfp.get_pdk().activate() + gf.get_component() instead of ubcpdk cells - _meep_api_styles: load gf.components.mmi1x2() under gf.gpdk - Delete _meep_straight.ipynb and _meep_sbend.ipynb (UBC PDK examples) - docs.yml: remove ubcpdk pip-install case (no longer required by any published notebook)
vvahidd
requested review from
cdaunt,
flaport,
joamatab and
nikosavola
as code owners
August 20, 2026 04:43
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 59.98% 60.92% +0.94%
==========================================
Files 94 97 +3
Lines 13334 14101 +767
Branches 2703 2859 +156
==========================================
+ Hits 7998 8591 +593
- Misses 4439 4589 +150
- Partials 897 921 +24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent / rationale
Changes introduced