ship cspdk--sample-projects in wheel - #311
Conversation
Migrate build backend from flit to hatchling and use force-include to ship the cspdk--sample-projects directory in the published wheel. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the build system in pyproject.toml from flit_core to hatchling and configures wheel targets. The review feedback points out that force-including 'cspdk--sample-projects' at the root of the wheel will pollute the global site-packages namespace, and suggests nesting it under the main 'cspdk' package instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| packages = ["cspdk"] | ||
|
|
||
| [tool.hatch.build.targets.wheel.force-include] | ||
| "cspdk--sample-projects" = "cspdk--sample-projects" |
There was a problem hiding this comment.
Including 'cspdk--sample-projects' at the root of the wheel will install it directly into the user's 'site-packages' directory as a top-level directory, polluting the global namespace. It is highly recommended to nest the sample projects under the main package namespace (e.g., 'cspdk/sample-projects') to keep the environment clean and allow programmatic access using importlib.resources.
| "cspdk--sample-projects" = "cspdk--sample-projects" | |
| "cspdk--sample-projects" = "cspdk/sample-projects" |
Move [tool.hatch.*] sections to correct alphabetical position among [tool.*] sections. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 participant
Closes #310
Migrates the build backend from flit to hatchling and uses
force-includeto ship thecspdk--sample-projectsdirectory in the published wheel.Reminder: AI-created PRs still require human review of the actual code changes before merge. I'll open the PR, but a human must review and approve it.