Conversation
There was a problem hiding this comment.
Code Review
This pull request updates gDRutils to version 1.9.7 and enhances the merge_MAE function to support metadata synthesis. New parameters allow for custom titles, descriptions, and source identifiers, with logic added to aggregate these from input experiments. Feedback indicates that the current implementation incorrectly discards metadata from subsequent MAEs and introduces inconsistent data structures in merge_metadata. There is also redundant logic regarding source name determination and metadata overwriting that should be refactored, along with a need for more robust handling of partially missing dataset names.
|
GJ! |
j-smola
left a comment
There was a problem hiding this comment.
The combined data will have nice metadata thanks to this task. That's great.
However, the problem with duplicate records still persists.
| DrugName | Gnumber | CellLineName | source_id |
|---|---|---|---|
| [ drug_001 | gnum1.1-1 | cellline_AB | mae_1 |
| [ drug_001 | gnum1.1-2 | cellline_AB | mae_1 |
| [ drug_001 | gnum1.1-1 | cellline_AB | mae_2 |
Hmm, I don't know what do you mean. Could you please provide the reproductive code? This task and PR were created to properly manage metadata for DSDB pushing |
Description
What changed?
Related JIRA issue: GDR-3306
Why was it changed?
To add support for merging metadata correctly
Checklist for sustainable code base
Logistic checklist
Screenshots (optional)