Skip to content

Gdr 3306#183

Merged
bczech merged 5 commits into
mainfrom
GDR-3306
Apr 16, 2026
Merged

Gdr 3306#183
bczech merged 5 commits into
mainfrom
GDR-3306

Conversation

@bczech
Copy link
Copy Markdown
Contributor

@bczech bczech commented Apr 14, 2026

Description

What changed?

Related JIRA issue: GDR-3306

Why was it changed?

To add support for merging metadata correctly

Checklist for sustainable code base

  • I added tests for any code changed/added
  • I added documentation for any code changed/added
  • I made sure naming of any new functions is self-explanatory and consistent

Logistic checklist

  • Package version bumped
  • Changelog updated

Screenshots (optional)

@bczech bczech requested a review from a team as a code owner April 14, 2026 07:04
@bczech bczech requested review from darsoo and gladkia and removed request for a team April 14, 2026 07:04
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates gDRutils to version 1.9.7 and enhances the merge_MAE function to support metadata synthesis. New parameters allow for custom titles, descriptions, and source identifiers, with logic added to aggregate these from input experiments. Feedback indicates that the current implementation incorrectly discards metadata from subsequent MAEs and introduces inconsistent data structures in merge_metadata. There is also redundant logic regarding source name determination and metadata overwriting that should be refactored, along with a need for more robust handling of partially missing dataset names.

Comment thread R/merge_SE.R
Comment thread R/merge_SE.R
Comment thread R/merge_SE.R
Comment thread R/merge_SE.R
Comment thread R/merge_SE.R
Comment thread R/merge_SE.R
@gladkia
Copy link
Copy Markdown
Collaborator

gladkia commented Apr 14, 2026

GJ!

Copy link
Copy Markdown
Contributor

@j-smola j-smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The combined data will have nice metadata thanks to this task. That's great.
However, the problem with duplicate records still persists.

DrugName Gnumber CellLineName source_id
[ drug_001 gnum1.1-1 cellline_AB mae_1
[ drug_001 gnum1.1-2 cellline_AB mae_1
[ drug_001 gnum1.1-1 cellline_AB mae_2

@bczech
Copy link
Copy Markdown
Contributor Author

bczech commented Apr 14, 2026

The combined data will have nice metadata thanks to this task. That's great. However, the problem with duplicate records still persists.

DrugName Gnumber CellLineName source_id
[ drug_001 gnum1.1-1 cellline_AB mae_1
[ drug_001 gnum1.1-2 cellline_AB mae_1
[ drug_001 gnum1.1-1 cellline_AB mae_2

Hmm, I don't know what do you mean. Could you please provide the reproductive code? This task and PR were created to properly manage metadata for DSDB pushing

@bczech bczech requested a review from j-smola April 14, 2026 09:28
@bczech bczech merged commit cc6fa62 into main Apr 16, 2026
3 of 4 checks passed
@bczech bczech deleted the GDR-3306 branch April 16, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants