-
Notifications
You must be signed in to change notification settings - Fork 0
chore: migrate test data files from qs to qs2 format (GDR-3351) #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
eb17022
chore: migrate test data files from qs to qs2 format (GDR-3351)
gladkia 76b5691
fix: handle qs2 extension in get_test_dataset_paths (GDR-3351)
gladkia 6cf1e20
chore: address reviewer feedback for GDR-3351 qs2 migration
gladkia 070228b
docs: regenerate man pages after GDR-3351 qs2 migration updates
gladkia 6daf9b1
docs: update metadata and vignettes for qs2 migration (GDR-3351)
gladkia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,72 +1,72 @@ | ||
| combo_2dose_nonoise: | ||
| name: finalMAE_combo_2dose_nonoise | ||
| file: finalMAE_combo_2dose_nonoise.qs | ||
| file: finalMAE_combo_2dose_nonoise.qs2 | ||
| script: generateComboNoNoiseData | ||
| imported_as_example: TRUE | ||
| description: "3 drugs x 2 co-treatment (1 drug at 2 doses) by 3 cell lines; co-treatment drug occurs also as a primary drug" | ||
| combo_2dose_nonoise2: | ||
| name: finalMAE_combo_2dose_nonoise2 | ||
| file: finalMAE_combo_2dose_nonoise2.qs | ||
| file: finalMAE_combo_2dose_nonoise2.qs2 | ||
| script: generateComboNoNoiseData2 | ||
| imported_as_example: FALSE | ||
| description: "3 drugs x 2 co-treatment (1 drug at 2 doses) by 3 cell lines; co-treatment drug occurs also as a primary drug" | ||
| combo_2dose_nonoise3: | ||
| name: finalMAE_combo_2dose_nonoise3 | ||
| file: finalMAE_combo_2dose_nonoise3.qs | ||
| file: finalMAE_combo_2dose_nonoise3.qs2 | ||
| script: generateComboNoNoiseData3 | ||
| imported_as_example: FALSE | ||
| description: "3 drugs x 2 co-treatment (1 drug at 2 doses) by 3 lines; co-treatment drug does NOT have single agent response" | ||
| combo_codilution_small: | ||
| name: finalMAE_combo_codilution_small | ||
| file: finalMAE_combo_codilution_small.qs | ||
| file: finalMAE_combo_codilution_small.qs2 | ||
| script: generateCodilutionSmall | ||
| imported_as_example: FALSE | ||
| description: "4 x 1 drugs (co-dilution) for 2 cell lines; no noise" | ||
| combo_codilution: | ||
| name: finalMAE_combo_codilution | ||
| file: finalMAE_combo_codilution.qs | ||
| file: finalMAE_combo_codilution.qs2 | ||
| script: generateCodilution | ||
| imported_as_example: FALSE | ||
| description: "12 x 1 drugs (co-dilution) for 8 cell lines; no noise" | ||
| combo_matrix_small: | ||
| name: finalMAE_combo_matrix_small | ||
| file: finalMAE_combo_matrix_small.qs | ||
| file: finalMAE_combo_matrix_small.qs2 | ||
| script: generateComboMatrixSmall | ||
| imported_as_example: FALSE | ||
| description: "3 x 2 drugs (matrix) for 2 cell lines; no noise" | ||
| combo_matrix: | ||
| name: finalMAE_combo_matrix | ||
| file: finalMAE_combo_matrix.qs | ||
| file: finalMAE_combo_matrix.qs2 | ||
| script: generateComboMatrix | ||
| imported_as_example: TRUE | ||
| description: "6 x 3 drugs (matrix) for 8 cell lines" | ||
| combo_triple: | ||
| name: finalMAE_combo_triple | ||
| file: finalMAE_combo_triple.qs | ||
| file: finalMAE_combo_triple.qs2 | ||
| script: generateTripleComboMatrix | ||
| imported_as_example: TRUE | ||
| description: "2 x 3 x 2 drugs (triple matrix) for 4 cell lines" | ||
| medium: | ||
| name: finalMAE_medium | ||
| file: finalMAE_medium.qs | ||
| file: finalMAE_medium.qs2 | ||
| script: generateMediumData | ||
| imported_as_example: TRUE | ||
| description: "40 drugs (6 different drug_moa) by 15 lines (3 tissues); single agent" | ||
| small_no_noise: | ||
| name: finalMAE_small_no_noise | ||
| file: finalMAE_small_no_noise.qs | ||
| file: finalMAE_small_no_noise.qs2 | ||
| script: generateNoNoiseRawData | ||
| imported_as_example: FALSE | ||
| description: "10 drugs (3 different drug_moa) by 10 lines (3 tissues); single agent - no noise in the data" | ||
| small: | ||
| name: finalMAE_small | ||
| file: finalMAE_small.qs | ||
| file: finalMAE_small.qs2 | ||
| script: generateNoiseRawData | ||
| imported_as_example: TRUE | ||
| description: "10 drugs (3 different drug_moa) by 10 lines (3 tissues); single agent" | ||
| wLigand: | ||
| name: finalMAE_wLigand | ||
| file: finalMAE_wLigand.qs | ||
| file: finalMAE_wLigand.qs2 | ||
| script: generateLigandData | ||
| imported_as_example: TRUE | ||
| description: "3 drugs by 4 lines (3 tissues); `Ligand = 0.1` as reference; single agent" |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration to
qs2appears to be incomplete. While the package description and dependencies have been updated, the utility functionget_test_dataset_paths()inR/get_test_datasets.Rstill contains hardcoded logic for the.qsextension. Specifically, line 37 usesgsub(".qs", "", ...)which will fail to correctly strip the new.qs2extension, resulting in incorrect dataset names (e.g., 'small2' instead of 'small'). Additionally, the docstring on line 7 of that file still refers to 'qs files'. Please updateR/get_test_datasets.Rto handle the new file format correctly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.