Skip to content

feat: extend linter config, add auto-changelog workflow and Conventional Commits guidelines#97

Open
bczech wants to merge 21 commits into
mainfrom
GDR-1014
Open

feat: extend linter config, add auto-changelog workflow and Conventional Commits guidelines#97
bczech wants to merge 21 commits into
mainfrom
GDR-1014

Conversation

@bczech
Copy link
Copy Markdown
Contributor

@bczech bczech commented May 8, 2026

Description

What changed?

  • Extended default linter config: enabled seq_linter, cyclocomp_linter, paste_linter, trailing_whitespace_linter, trailing_blank_lines_linter; added undesirable_operator_linter to forbid %>% and |>; fixed typo in read.csv warning message
  • Added reusable GitHub Actions workflow auto-changelog.yml that uses Claude API to auto-bump version in DESCRIPTION and generate NEWS.md entry when a PR does not include those changes
  • Added CONTRIBUTING.md with Conventional Commits guidelines and style rules
  • Added non-blocking reusable CI workflow conventional-commit-check.yml that warns if PR title does not follow Conventional Commits format

Related JIRA issue(s)

Checklist for sustainable code base

  • I added/adjusted tests for any code changed/added
  • I added/adjusted documentation for any code changed/added
  • I made sure naming of any new functions/arguments is self-explanatory and consistent

Logistic checklist

  • Package version bumped
  • NEWS updated

@bczech bczech requested a review from a team as a code owner May 8, 2026 10:19
@bczech bczech requested review from darsoo and j-smola May 8, 2026 10:19
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package to version 1.11.3, adding a CONTRIBUTING.md file that outlines commit message conventions and style guidelines. The linter configuration has been expanded to include cyclocomp_linter, paste_linter, and a new undesirable_operator_linter to forbid pipe operators, while also enabling default linters for sequences and whitespace. Feedback was provided to unify the linter configuration across different lintr versions to ensure consistency and simplify maintenance.

Comment thread R/linters_config.R Outdated
Comment thread R/linters_config.R Outdated
Comment thread .github/workflows/auto-changelog.yml Outdated
Comment thread .github/workflows/conventional-commit-check.yml
Copy link
Copy Markdown
Contributor

@gladkia gladkia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

Copy link
Copy Markdown
Contributor

@gladkia gladkia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants