Skip to content

chore: sync main with Bioconductor devel (GDR-3372)#95

Merged
gladkia merged 4 commits into
mainfrom
GDR-3372
Apr 30, 2026
Merged

chore: sync main with Bioconductor devel (GDR-3372)#95
gladkia merged 4 commits into
mainfrom
GDR-3372

Conversation

@gladkia
Copy link
Copy Markdown
Contributor

@gladkia gladkia commented Apr 29, 2026

Description

What changed?

Related JIRA issue: https://globaljira.roche.com/browse/GDR-3372

Synced main branch with Bioconductor upstream/devel. 1 change in DESCRIPTION (version bump by Bioconductor).

Why was it changed?

Bioconductor created RELEASE_3_23 branch - maintainers required to sync GitHub with Bioconductor git server.

Checklist for sustainable code base

  • I added tests for any code changed/added (N/A - version bump only)
  • I added documentation for any code changed/added (N/A)
  • I made sure naming of any new functions is self-explanatory and consistent (N/A)

Logistic checklist

  • Package version bumped (done by Bioconductor)
  • Changelog updated

Screenshots (optional)

@gladkia gladkia requested a review from a team as a code owner April 29, 2026 12:58
@gladkia gladkia requested review from bczech and darsoo April 29, 2026 12:58
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version of the gDRstyle package from 1.9.1 to 1.11.0. Feedback suggests that the NEWS.md file should also be updated to document this version bump, ensuring consistency with the project's standard release process.

Comment thread DESCRIPTION Outdated
Type: Package
Title: A package with style requirements for the gDR suite
Version: 1.9.1
Version: 1.11.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version has been bumped to 1.11.0, but the NEWS.md file has not been updated in this pull request. Following the project's established pattern for synchronization PRs (as seen in previous entries for versions 1.9.1, 1.7.1, etc.), a new entry should be added to NEWS.md to document the synchronization with Bioconductor devel.

@gladkia gladkia merged commit 59cf24b into main Apr 30, 2026
2 of 3 checks passed
@gladkia gladkia deleted the GDR-3372 branch April 30, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants