Conversation
Address lint violations from updated gDRstyle rules: - Fix trailing whitespace and blank lines - Replace nrow/ncol with NROW/NCOL - Fix paste_linter (paste0+collapse, toString, strrep, file.path) - Fix seq_linter (seq_along, seq_len) - Refactor cyclocomp_linter violations (extract helper functions) - Fix test linters (yoda, expect_true_false) - Remove undesirable operators (|> pipes)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the D300 and EnVision data import logic by extracting complex parsing and matrix-filling routines into dedicated internal helper functions, enhancing modularity and readability. Robustness is improved through the use of NCOL() and NROW() for dimension checks and safer XML dimension extraction. Additionally, the PR updates test dependencies from qs2 to qs and performs extensive whitespace cleanup across the codebase. Review feedback suggests further optimizing matrix initialization in the new helper functions by avoiding unnecessary rep() calls.
| conc_mat <- matrix(rep("", nwells), nrow = nrow, ncol = ncol) | ||
| drug_mat <- matrix(rep("", nwells), nrow = nrow, ncol = ncol) |
There was a problem hiding this comment.
For slightly better performance and readability, you can initialize the matrices directly without using rep().
conc_mat <- matrix("", nrow = nrow, ncol = ncol)
drug_mat <- matrix("", nrow = nrow, ncol = ncol)| conc_mat <- matrix(rep("", nwells), nrow = nrow, ncol = ncol) | ||
| drug_mat <- matrix(rep("", nwells), nrow = nrow, ncol = ncol) |
There was a problem hiding this comment.
For slightly better performance and readability, you can initialize the matrices directly without using rep().
conc_mat <- matrix("", nrow = nrow, ncol = ncol)
drug_mat <- matrix("", nrow = nrow, ncol = ncol)
2 participants
Description
What changed?
Related JIRA issue: GDR-1014
Why was it changed?
Updated gDRstyle linting rules require compliance across all gDR packages.
Checklist for sustainable code base
Logistic checklist