Skip to content

chore: migrate from qs to qs2 package (GDR-3351)#117

Merged
gladkia merged 4 commits into
mainfrom
GDR-3351
Apr 19, 2026
Merged

chore: migrate from qs to qs2 package (GDR-3351)#117
gladkia merged 4 commits into
mainfrom
GDR-3351

Conversation

@gladkia
Copy link
Copy Markdown
Contributor

@gladkia gladkia commented Apr 13, 2026

Description

What changed?

Related JIRA issue: GDR-3351

Replaced all usage of the archived qs package with qs2:

  • qs::qread()qs2::qs_read()
  • qs::qsave()qs2::qs_save()
  • File extensions updated from .qs to .qs2
  • Dependency in DESCRIPTION updated accordingly
  • Tests and vignettes updated to reflect the new API

Why was it changed?

The qs package was archived on CRAN on January 17, 2026 and will not be included in Bioconductor 3.23.
The qs2 package is its official successor with an incompatible binary format.

Checklist for sustainable code base

  • I added tests for any code changed/added
  • I added documentation for any code changed/added
  • I made sure naming of any new functions is self-explanatory and consistent

Logistic checklist

  • Package version bumped
  • Changelog updated

@gladkia gladkia requested a review from a team as a code owner April 13, 2026 11:19
@gladkia gladkia requested review from darsoo and j-smola and removed request for a team April 13, 2026 11:19
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the package from the qs dependency to qs2, updating function calls and file extensions across the codebase, tests, and vignettes. Feedback indicates that qs2 should be moved from Suggests to Imports since it is used in exported functions. Additionally, a bug was identified in the 384-well plate test where 96-well data variables were incorrectly reused, and a misleading variable name in the test suite should be renamed for clarity.

Comment thread DESCRIPTION Outdated
Comment thread tests/testthat/test-D300.R Outdated
Comment thread tests/testthat/test-D300.R Outdated
Copy link
Copy Markdown
Contributor

@j-smola j-smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update doc with devtools::document().

What with RUN Rscript -e 'BiocManager::install(c("BiocStyle", "qs"))' in DOCKERFILE?

@gladkia
Copy link
Copy Markdown
Contributor Author

gladkia commented Apr 13, 2026

Please, update doc with devtools::document().

What with RUN Rscript -e 'BiocManager::install(c("BiocStyle", "qs"))' in DOCKERFILE?
Done.

Copy link
Copy Markdown
Contributor

@bczech bczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reoxygenate

@gladkia gladkia merged commit 647306a into main Apr 19, 2026
3 of 4 checks passed
@gladkia gladkia deleted the GDR-3351 branch April 19, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants