Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the package from the qs dependency to qs2, updating function calls and file extensions across the codebase, tests, and vignettes. Feedback indicates that qs2 should be moved from Suggests to Imports since it is used in exported functions. Additionally, a bug was identified in the 384-well plate test where 96-well data variables were incorrectly reused, and a misleading variable name in the test suite should be renamed for clarity.
j-smola
left a comment
There was a problem hiding this comment.
Please, update doc with devtools::document().
What with RUN Rscript -e 'BiocManager::install(c("BiocStyle", "qs"))' in DOCKERFILE?
|
Description
What changed?
Related JIRA issue: GDR-3351
Replaced all usage of the archived
qspackage withqs2:qs::qread()→qs2::qs_read()qs::qsave()→qs2::qs_save().qsto.qs2Why was it changed?
The
qspackage was archived on CRAN on January 17, 2026 and will not be included in Bioconductor 3.23.The
qs2package is its official successor with an incompatible binary format.Checklist for sustainable code base
Logistic checklist