Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates gDRcore to version 1.9.8 and addresses C++ compilation errors on R-devel by transitioning from STRING_PTR to STRING_PTR_RO. A critical review comment identifies that using const_cast to sort a pointer from STRING_PTR_RO is unsafe in the R C API, particularly with ALTREP objects, and recommends using a temporary buffer with SET_STRING_ELT instead.
darsoo
approved these changes
Apr 27, 2026
const_cast on STRING_PTR_RO pointer is UB for ALTREP objects — the backing store may be read-only memory. Copy through a temporary vector and write back via SET_STRING_ELT (official write-barrier API).
bczech
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What changed?
STRING_PTRwithSTRING_PTR_ROinsrc/gDRcore.cppRelated JIRA issue: GDR-3367
Why was it changed?
STRING_PTRwas removed from the R C API in R-devel (Bioc 3.23).Linux build on Bioconductor failed with "STRING_PTR was not declared in this scope".
macOS build was unaffected. Fix uses
STRING_PTR_RO(read-only access) withconst_castwhere in-place sorting requires mutable iterators.Checklist for sustainable code base
Logistic checklist