Fix broken Javascript -> action.py RPC calls #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 1, 2021 02:04
Method expects no parameters, so extra parameters passed from Javascript [0, 0] were causing an exception to be thrown
Method expects no parameters, so extra parameters passed from Javascript [0, 0] were causing an exception to be thrown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my testing, all the updates to
actions.pywith regard to the methods that get called from Javascript seem to be working correctly, except foracceptTriangleCalibrationResultsandacceptHoleyCalibrationResults. These two invocations were being passed extra parameters to the Python functions, causing a Python exception to get thrown. I simply removed these extra parameters.