Skip to content

feat: Expose attach config from mod host as env var #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
garyttierney wants to merge 4 commits into
base: chore/launch-refactor
Choose a base branch
from
Open

feat: Expose attach config from mod host as env var #554

garyttierney wants to merge 4 commits into from

Conversation

@garyttierney
Copy link
Owner

@garyttierney garyttierney commented Oct 2, 2025

No description provided.

@github-project-automation github-project-automation bot moved this to Todo in me3 Oct 2, 2025
@github-actions github-actions bot added the feature New feature label Oct 2, 2025
@garyttierney garyttierney force-pushed the feat/expose-attach-config branch from 8ea122b to 1bc8094 Compare October 2, 2025 20:30
@Dasaav-dsv
Copy link
Collaborator

Dasaav-dsv commented Oct 2, 2025

Not sure about exposing the entire me3_launcher_attach_protocol::AttachConfig as an API endpoint, maybe it's better to use another type where we can guarantee a more stable interface without limiting ourselves in the AttachConfig?

@garyttierney garyttierney changed the base branch from main to chore/launch-refactor January 18, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dasaav-dsv Dasaav-dsv Awaiting requested review from Dasaav-dsv Dasaav-dsv is a code owner

Assignees

No one assigned

Labels

feature New feature

Projects

me3
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garyttierney @Dasaav-dsv