Skip to content

Bugfix/error handling for expired jobs #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: feat/acp
Choose a base branch
from
Open

Bugfix/error handling for expired jobs #149

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a35b532
fix: better error handling for expired jobs
jxx016 May 1, 2025
5f46ca7
changing error handling to UTC
jxx016 May 1, 2025
ff90cb5
change to check for cancelled jobs instead
jxx016 May 1, 2025
0595cb6
adding check for respondJob and payJob too
jxx016 May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions plugins/acp/acp_plugin_gamesdk/acp_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,10 @@ def _respond_job_executable(self, jobId: int, decision: str, reasoning: str, twe
try:
state = self.get_acp_state()

# Check if job is cancelled
if any(c["jobId"] == jobId for c in state["jobs"]["cancelled"]):
return FunctionResultStatus.FAILED, "Cannot respond - this job has been cancelled", {}

job = next(
(c for c in state["jobs"]["active"]["asASeller"] if c["jobId"] == jobId),
None
Expand Down Expand Up @@ -514,6 +518,10 @@ def _pay_job_executable(self, jobId: int, amount: float, reasoning: str, tweetCo
try:
state = self.get_acp_state()

# Check if job is cancelled
if any(c["jobId"] == jobId for c in state["jobs"]["cancelled"]):
return FunctionResultStatus.FAILED, "Cannot pay - this job has been cancelled", {}

job = next(
(c for c in state["jobs"]["active"]["asABuyer"] if c["jobId"] == jobId),
None
Expand Down Expand Up @@ -607,6 +615,10 @@ def _deliver_job_executable(self, jobId: int, deliverableType: str, deliverable:

try:
state = self.get_acp_state()

# Check if job is cancelled
if any(c["jobId"] == jobId for c in state["jobs"]["cancelled"]):
return FunctionResultStatus.FAILED, "Cannot deliver - this job has been cancelled", {}

job = next(
(c for c in state["jobs"]["active"]["asASeller"] if c["jobId"] == jobId),
Expand Down