Skip to content

Remove Job.params #21075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 20, 2025
Merged

Remove Job.params #21075

merged 5 commits into from
Oct 20, 2025

Conversation

@jdavcs
Copy link
Member

@jdavcs jdavcs commented Oct 15, 2025 •
edited
Loading

Ref: #20981

To do:

  • Check code base for references to a model.Job.params object

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added this to the 26.0 milestone Oct 15, 2025
@jdavcs jdavcs added kind/refactoring cleanup or refactoring of existing code, no functional changes area/jobs area/database Galaxy's database or data access layer labels Oct 15, 2025
@jdavcs jdavcs changed the title [WIP] Remove Job.params Remove Job.params Oct 16, 2025
@jdavcs
Copy link
Member Author

jdavcs commented Oct 16, 2025

Ready for review. Test failures unrelated.

@jdavcs jdavcs marked this pull request as ready for review October 16, 2025 20:56
@jdavcs jdavcs requested review from a team and jmchilton October 16, 2025 20:56
@jmchilton jmchilton merged commit 0420a1d into galaxyproject:dev Oct 20, 2025
57 of 62 checks passed
@jmchilton
Copy link
Member

Thanks so much - I really appreciate this!

@nsoranzo nsoranzo mentioned this pull request Oct 21, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmchilton jmchilton Awaiting requested review from jmchilton

Assignees

No one assigned

Labels

area/database Galaxy's database or data access layer area/jobs kind/refactoring cleanup or refactoring of existing code, no functional changes

Projects

None yet

Milestone

26.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jdavcs @jmchilton