Publish the Docker image to GHCR#90
Draft
dannon wants to merge 2 commits into
Draft
Conversation
The final stage copied /root/.local out of the uv builder, but that path never exists there (uv lives at /usr/local/bin and nothing installs into /root/.local), so the build died at that step with a checksum-not-found error. The runtime doesn't need uv anyway -- the entrypoint is the galaxy-mcp console script in /app/.venv/bin. Also add a .dockerignore so local builds don't drag .env, .venv, and the tool caches into the context.
Nothing ever built or pushed the container the README pointed at, so galaxyproject/galaxy-mcp didn't actually exist on any registry. This adds a workflow that builds mcp-server-galaxy-py/Dockerfile and pushes ghcr.io/galaxyproject/galaxy-mcp -- versioned tags plus latest on release, an edge tag on main, and a build-only validation pass on PRs so a broken Dockerfile can't slip through again. Auth is the built-in GITHUB_TOKEN, no secrets needed. README now points at the ghcr.io image and the dev docs describe the workflow.
|
Thank you! It would be great to publish that Docker image. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README's Container Usage section points at
galaxyproject/galaxy-mcp, but that image was never published -- nothing in CI built or pushed it, sodocker run galaxyproject/galaxy-mcpfails to pull. This wires up publishing.While getting a local build to pass, I hit a latent Dockerfile bug: the final stage did
COPY --from=uv /root/.local /root/.local, but that path doesn't exist in the uv builder (uv lives at/usr/local/bin, nothing installs to/root/.local), so the build errored with a checksum-not-found. Dropped it -- the runtime doesn't need uv, the entrypoint is the venv console script. Also added a.dockerignore.New
docker-publish.ymlbuildsmcp-server-galaxy-py/Dockerfileand pushesghcr.io/galaxyproject/galaxy-mcp: versioned +lateston release,edgeon main, and a build-only validation pass on PRs so a broken Dockerfile can't slip through again. Auth is the built-inGITHUB_TOKEN-- no secrets. Multi-arch (amd64 + arm64) on publish.Verified locally: image builds, stdio
--helpruns, HTTP transport binds :8000.