Skip to content

Small fix that adds ece.time - #440

Merged
torrinba merged 2 commits into
masterfrom
ssd/add_ece_time
Sep 22, 2026
Merged

torrinba merged 2 commits into
masterfrom
ssd/add_ece_time

Conversation

@AreWeDreaming

Copy link
Copy Markdown
Collaborator

Description

Add ece.time for d3d (the IDS is homogeneous)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Other (please describe):

Testing

Works for ECRad

Pre-Merge Checklist

  • OMFIT has been tested with this OMAS version and you will create a PR on OMFIT that updates the OMAS submodule once this has been merged. -> Not needed since it is a simple addition
  • Version number has been incremented if this is a major modification or important bug fix
    • To increment the version: Edit the version number in omas/version file
    • Follow semantic versioning: MAJOR.MINOR.PATCH (e.g., 0.94.2 → 0.94.3 for bug fixes, 0.94.2 → 0.95.0 for new features)
    • A GitHub release will be automatically created when this PR is merged if the version number has changed

Additional Notes

Comment thread omas/machine_mappings/d3d.py Resolved
Comment thread omas/machine_mappings/d3d.py Resolved
Co-authored-by: Severin Denk <60154343+AreWeDreaming@users.noreply.github.com>

@torrinba torrinba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised you haven't suggested this change in imas_composer as well. Is that forthcoming?

@AreWeDreaming

Copy link
Copy Markdown
Collaborator Author

This was actually for ECRad which still uses Omas

@torrinba
torrinba merged commit 8ae62bf into master Sep 22, 2026
4 of 8 checks passed
@torrinba
torrinba deleted the ssd/add_ece_time branch September 22, 2026 01:32
@torrinba

Copy link
Copy Markdown
Collaborator

This was actually for ECRad which still uses Omas

I realize that, but it seems equally relevant to any use of the ECE data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants