Fix a few bugs with CurrentKeyModifiers - #6493
Open
dweymouth wants to merge 1 commit into
Open
Conversation
…t, clear on background
Member
|
Try a rebase to get test fixes - though there are some issues I don't recognise there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6486
Also synchronizes currentKeyModifiers on mouse click events from GLFW (which carry the freshest key modifier state from the OS), and clear it on app backgrounding, to prevent a held, then unfocus, then released modifier key from being reported as if it were stuck on.
One note is that since we can only sync this info on mouse clicks and key press/release events, the CurrentKeyModifiers API will unavoidably be potentially stale if called after an application is re-focused but before any mouse clicks (an existing unsolvable issue).
Checklist: