Add option to allow decoding CBOR floats into the Go int types.#777
Draft
benluddy wants to merge 1 commit into
Draft
Add option to allow decoding CBOR floats into the Go int types.#777benluddy wants to merge 1 commit into
benluddy wants to merge 1 commit into
Conversation
The default behavior remains unchanged (CBOR floats can only be decoded into Go floats). By configuring the option, integral-valued CBOR floats can be decoded into the Go integer and unsigned integer types as long as the destination type is capable of faithfully representing their value. Signed-off-by: Ben Luddy <bluddy@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default behavior remains unchanged (CBOR floats can only be decoded into Go floats). By configuring the option, integral-valued CBOR floats can be decoded into the Go integer and unsigned integer types as long as the destination type is capable of faithfully representing their value.
PR Was Proposed and Welcomed in Currently Open Issue
Checklist (for code PR only, ignore for docs PR)
Last line of each commit message should be in this format:
Signed-off-by: Firstname Lastname firstname.lastname@example.com
(see next section).
Certify the Developer's Certificate of Origin 1.1
the Developer Certificate of Origin 1.1.