Skip to content

Add option to allow decoding CBOR floats into the Go int types.#777

Draft
benluddy wants to merge 1 commit into
fxamacker:masterfrom
benluddy:float-to-int
Draft

Add option to allow decoding CBOR floats into the Go int types.#777
benluddy wants to merge 1 commit into
fxamacker:masterfrom
benluddy:float-to-int

Conversation

@benluddy
Copy link
Copy Markdown
Contributor

@benluddy benluddy commented May 19, 2026

Description

The default behavior remains unchanged (CBOR floats can only be decoded into Go floats). By configuring the option, integral-valued CBOR floats can be decoded into the Go integer and unsigned integer types as long as the destination type is capable of faithfully representing their value.

PR Was Proposed and Welcomed in Currently Open Issue

  • This PR was proposed and welcomed by maintainer(s) in issue #___
  • Closes or Updates Issue #___

Checklist (for code PR only, ignore for docs PR)

  • Include unit tests that cover the new code
  • Pass all unit tests
  • Pass all lint checks in CI (goimports, gosec, staticcheck, etc.)
  • Sign each commit with your real name and email.
    Last line of each commit message should be in this format:
    Signed-off-by: Firstname Lastname firstname.lastname@example.com
  • Certify the Developer's Certificate of Origin 1.1
    (see next section).

Certify the Developer's Certificate of Origin 1.1

  • By marking this item as completed, I certify
    the Developer Certificate of Origin 1.1.
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
660 York Street, Suite 102,
San Francisco, CA 94110 USA

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

The default behavior remains unchanged (CBOR floats can only be decoded into Go floats). By
configuring the option, integral-valued CBOR floats can be decoded into the Go integer and unsigned
integer types as long as the destination type is capable of faithfully representing their value.

Signed-off-by: Ben Luddy <bluddy@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant