Contributors表示 #400

Hosoda-abo · 2025-12-08T09:04:00Z

概要

やったこと

確認したこと

[ ]

UI 差分

Before	After

メモ

API Response 用の型が必要 (note by @kantacky)

GitHubProfile型を作成

…ibutorRepository

…rRepository

…ository

…vice GitHubContributorServiceを作成

…wState GitHubContributorViewStateを作成

* Create GitHubContributorVieeModel * Create githubContributorViewModelTest * Refactor GithubContributorViewmodel to use a class-level service instance for improved code clarity and efficiency (#417) --------- Co-authored-by: Kanta Oikawa <[email protected]>

* Create GitHubContributorVieeModel * Create githubContributorViewModelTest * Create githubContributorScreen * Fix Copilot error * Transition from the Settings Screen to the GitHub Contributor Screen * Fix copilot error * Fix the classname GitHubContributorViewModelProvider * Display usename * Update lib/feature/setting/settings.dart Co-authored-by: Kanta Oikawa <[email protected]> * Refactor GithubContributorViewmodel to use a class-level service instance for improved code clarity and efficiency (#417) --------- Co-authored-by: Kanta Oikawa <[email protected]>

github-actions · 2025-12-25T12:09:29Z

	2 Warnings
⚠️	このPRは大きすぎます (556 lines)。小さなPRに分割することを検討してください。
⚠️	アプリコードが変更されていますが、テストが追加されていません。テストの追加を検討してください。

	2 Messages
📖	追加されたファイル: lib/domain/github_profile.dart, lib/feature/github_contributor/github_contributor_screen.dart, lib/feature/github_contributor/github_contributor_service.dart, lib/feature/github_contributor/github_contributor_viewmodel.dart, lib/feature/github_contributor/github_contributor_viewstate.dart, lib/repository/github_contoributor_repository.dart, test/feature/github_contributors/github_contributor_service_test.dart, test/feature/github_contributors/github_contributor_service_test.mocks.dart, test/feature/github_contributors/github_contributor_viewmodel_test.dart, test/feature/github_contributors/github_contributor_viewmodel_test.mocks.dart
📖	Dangerのチェックが完了しました! 🎉

Generated by 🚫 Danger

Copilot

Pull request overview

This PR implements a GitHub Contributors display feature that fetches and shows the list of contributors from the GitHub API. It follows clean architecture principles with domain, repository, service, and presentation layers, and includes comprehensive test coverage.

Adds a complete GitHub contributors feature with clean architecture separation
Implements UI screen with pull-to-refresh functionality
Includes comprehensive unit tests for service and viewmodel layers

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
lib/domain/github_profile.dart	Defines the domain model for GitHub profile data with JSON serialization
lib/repository/github_contoributor_repository.dart	Implements repository layer to fetch contributors from GitHub API
lib/feature/github_contributor/github_contributor_service.dart	Service layer that wraps repository calls
lib/feature/github_contributor/github_contributor_viewmodel.dart	ViewModel managing state and business logic for contributors screen
lib/feature/github_contributor/github_contributor_viewstate.dart	View state model holding contributors list
lib/feature/github_contributor/github_contributor_screen.dart	UI screen displaying contributors with pull-to-refresh
lib/feature/setting/settings.dart	Adds navigation to contributors screen from settings
test/feature/github_contributors/github_contributor_service_test.dart	Unit tests for service layer
test/feature/github_contributors/github_contributor_viewmodel_test.dart	Unit tests for viewmodel layer
test/feature/github_contributors/github_contributor_service_test.mocks.dart	Generated mocks for service tests
test/feature/github_contributors/github_contributor_viewmodel_test.mocks.dart	Generated mocks for viewmodel tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-25T12:13:07Z

lib/feature/github_contributor/github_contributor_service.dart

@@ -0,0 +1,13 @@
+import 'package:dotto/domain/github_profile.dart';
+import 'package:dotto/repository/github_contoributor_repository.dart';


The import path contains a typo: "contoributor" should be "contributor".

Suggested change

import 'package:dotto/repository/github_contoributor_repository.dart';

import 'package:dotto/repository/github_contributor_repository.dart';

Copilot · 2025-12-25T12:13:07Z

test/feature/github_contributors/github_contributor_service_test.dart

+final GitHubContributorServiceProvider = Provider<GitHubContributorService>(
+  GitHubContributorService.new,
+);


Provider naming should follow Dart naming conventions. Variable names should use lowerCamelCase, not UpperCamelCase. This should be gitHubContributorServiceProvider instead of GitHubContributorServiceProvider.

Copilot · 2025-12-25T12:13:07Z

test/feature/github_contributors/github_contributor_service_test.dart

+      ).thenAnswer((_) async => testGitHubProfiles);
+
+      final container = createContainer();
+      final service = container.read(githubContributionRepositoryProvider);


Inconsistent provider usage. Line 54 uses githubContributionRepositoryProvider which is the repository provider, but the test should be reading the service provider. This appears to be testing the repository directly instead of the service layer.

Suggested change

final service = container.read(githubContributionRepositoryProvider);

final service = container.read(GitHubContributorServiceProvider);

Copilot · 2025-12-25T12:13:08Z

test/feature/github_contributors/github_contributor_viewmodel_test.dart

+import 'github_contributor_viewmodel_test.mocks.dart';
+
+abstract interface class Listener<T> {
+  void call(T? previous, T next);


The signature for the Listener interface is inconsistent. The call method expects T next (non-nullable) but the mock implementation at line 58 uses T? next (nullable). This creates a mismatch between the interface and its implementation.

Copilot · 2025-12-25T12:13:08Z

lib/repository/github_contoributor_repository.dart

+        throw Exception('Failed to get contributors');
+      }
+
+      final data = response.data;
+      if (data == null || data is! List) {
+        throw Exception('Failed to get contributors');


The error messages for different failure scenarios are identical, making debugging difficult. Consider providing more specific error messages for different cases: status code != 200 vs invalid response data structure.

Suggested change

throw Exception('Failed to get contributors');

}

final data = response.data;

if (data == null || data is! List) {

throw Exception('Failed to get contributors');

throw Exception(

'Failed to get contributors: HTTP ${response.statusCode}',

);

}

final data = response.data;

if (data == null || data is! List) {

throw Exception('Failed to get contributors: invalid response format');

Copilot · 2025-12-25T12:13:08Z

lib/repository/github_contoributor_repository.dart

@@ -0,0 +1,46 @@
+import 'package:dotto/domain/github_profile.dart';


The filename contains a typo: "contoributor" should be "contributor". This affects the import path used throughout the codebase.

Copilot · 2025-12-25T12:13:08Z

test/feature/github_contributors/github_contributor_viewmodel_test.dart

+import 'package:dotto/domain/github_profile.dart';
+import 'package:dotto/feature/github_contributor/github_contributor_viewmodel.dart';
+import 'package:dotto/feature/github_contributor/github_contributor_viewstate.dart';
+import 'package:dotto/repository/github_contoributor_repository.dart';


The import path contains a typo: "contoributor" should be "contributor".

Suggested change

import 'package:dotto/repository/github_contoributor_repository.dart';

import 'package:dotto/repository/github_contributor_repository.dart';

Copilot · 2025-12-25T12:13:09Z

test/feature/github_contributors/github_contributor_service_test.dart

@@ -0,0 +1,98 @@
+import 'package:dotto/domain/github_profile.dart';
+import 'package:dotto/feature/github_contributor/github_contributor_service.dart';
+import 'package:dotto/repository/github_contoributor_repository.dart';


The import path contains a typo: "contoributor" should be "contributor".

Suggested change

import 'package:dotto/repository/github_contoributor_repository.dart';

import 'package:dotto/repository/github_contributor_repository.dart';

Copilot · 2025-12-25T12:13:09Z

lib/repository/github_contoributor_repository.dart

+  @override
+  Future<List<GitHubProfile>> getContributors() async {
+    try {
+      final dio = Dio();


A new Dio instance is created on every API call, which is inefficient and prevents proper configuration reuse (headers, timeouts, interceptors). The Dio instance should be injected as a dependency or created once and reused.

Hosoda-abo and others added 6 commits December 8, 2025 16:31

create contributor.dart

5d632e9

Create GitHubProfile type

6a9edae

Create GitHubProfile

1abd01a

Rename contributor.dart to github_profile.dart

7109ab7

Rename part file

19d8693

Merge pull request #399 from fun-dotto/issue/383-githubProfile

1904bd4

GitHubProfile型を作成

Hosoda-abo self-assigned this Dec 8, 2025

Hosoda-abo and others added 14 commits December 9, 2025 13:03

Add fromJson

861fd29

Create abstract class

320cac9

Create githubContributionRepositoryProvider

9f07068

Create GitHubContributorImpl

7507005

Merge remote-tracking branch 'origin/main' into issue/384-GitHubContr…

a2d8ae7

…ibutorRepository

Merge remote-tracking branch 'origin/main' into issue/324-contributors

200be56

Merge branch 'issue/324-contributors' into issue/384-GitHubContributo…

dc008b5

…rRepository

Merge pull request #404 from fun-dotto/issue/384-GitHubContributorRep…

90cdf50

…ository

Create getContributors method

4bd0e81

Create test

1c27adb

Create GitHubContributorViewState

c401584

Merge pull request #408 from fun-dotto/issue/385-githubContributorSer…

17a17c9

…vice GitHubContributorServiceを作成

Merge pull request #409 from fun-dotto/issue/386-githubContributorVie…

88a2b70

…wState GitHubContributorViewStateを作成

Merge remote-tracking branch 'origin/main' into issue/324-contributors

7c4d580

kantacky added this to the 251225_1.7.0 milestone Dec 23, 2025

Hosoda-abo and others added 2 commits December 25, 2025 20:33

Hosoda-abo marked this pull request as ready for review December 25, 2025 12:08

Hosoda-abo requested review from a team, Copilot, hikaru-0602 and kantacky December 25, 2025 12:08

Hosoda-abo requested a review from masaya-osuga December 25, 2025 12:08

Copilot started reviewing on behalf of Hosoda-abo December 25, 2025 12:09 View session

Hosoda-abo requested a review from ryka-1104 December 25, 2025 12:09

Copilot AI reviewed Dec 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Contributors表示 #400

Contributors表示 #400

Uh oh!

Hosoda-abo commented Dec 8, 2025 •

edited by kantacky

Loading

Uh oh!

github-actions bot commented Dec 25, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 25, 2025

Uh oh!

Copilot AI Dec 25, 2025

Uh oh!

Copilot AI Dec 25, 2025

Uh oh!

Copilot AI Dec 25, 2025

Uh oh!

Copilot AI Dec 25, 2025

Uh oh!

Copilot AI Dec 25, 2025

Uh oh!

Copilot AI Dec 25, 2025

Uh oh!

Copilot AI Dec 25, 2025

Uh oh!

Copilot AI Dec 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,13 @@
		import 'package:dotto/domain/github_profile.dart';
		import 'package:dotto/repository/github_contoributor_repository.dart';

	final service = container.read(githubContributionRepositoryProvider);
	final service = container.read(GitHubContributorServiceProvider);

		@@ -0,0 +1,46 @@
		import 'package:dotto/domain/github_profile.dart';

Contributors表示 #400

Are you sure you want to change the base?

Contributors表示 #400

Uh oh!

Conversation

Hosoda-abo commented Dec 8, 2025 • edited by kantacky Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

概要

やったこと

関連する Issue

確認したこと

UI 差分

コメント

メモ

Uh oh!

github-actions bot commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Hosoda-abo commented Dec 8, 2025 •

edited by kantacky

Loading

github-actions bot commented Dec 25, 2025 •

edited

Loading