Skip to content

User is on desktop but gets identified as a mobile user#48

Open
fulopkovacs wants to merge 2 commits into
mainfrom
get-started-issue
Open

User is on desktop but gets identified as a mobile user#48
fulopkovacs wants to merge 2 commits into
mainfrom
get-started-issue

Conversation

@fulopkovacs

@fulopkovacs fulopkovacs commented Jun 9, 2026

Copy link
Copy Markdown
Owner

See this tweeet.

Summary by CodeRabbit

  • Bug Fixes

    • Removed automatic mobile page redirect behavior, so mobile visitors will no longer be redirected to a separate mobile page.
  • Chores

    • Updated workspace build script configuration to explicitly allow selected native build tools.
    • Disabled two internal platform modules that are no longer active.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a6a5e440-57c8-4ebe-80c1-f24881054cbe

📥 Commits

Reviewing files that changed from the base of the PR and between e08a790 and ea56878.

📒 Files selected for processing (3)
  • pnpm-workspace.yaml
  • src/routes/__root.tsx
  • src/server/functions/getIsMobile.ts
💤 Files with no reviewable changes (2)
  • src/server/functions/getIsMobile.ts
  • src/routes/__root.tsx
✅ Files skipped from review due to trivial changes (1)
  • pnpm-workspace.yaml

Walkthrough

This PR disables two local MCP integrations, adds pnpm workspace allowBuilds for native packages, and removes server-side mobile detection plus the root-route automatic redirect to /mobile.

Changes

Configuration and Mobile Redirect Cleanup

Layer / File(s) Summary
MCP Integration Disable
opencode.json
Both codemogger and memelord MCP integrations are disabled by setting enabled: false while preserving memelord's command and environment configuration.
pnpm Build Configuration
pnpm-workspace.yaml
New allowBuilds block enables build scripts for better-sqlite3, esbuild, sharp, and workerd.
Mobile Redirect Removal
src/routes/__root.tsx, src/server/functions/getIsMobile.ts
Root route's beforeLoad handler that redirected mobile visitors to /mobile is removed along with the redirect and getIsMobile imports, and the getIsMobile server function module is deleted.

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main issue being addressed: removing mobile detection logic that was incorrectly identifying desktop users as mobile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch get-started-issue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant