Conversation
shouze
commented
Feb 19, 2026
- v1.0.5
- v1.0.5
|
Coverage after merging chore-release-v1.0.5 into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Pull request overview
Bumps the project version to v1.0.5 and adjusts the CD workflow artifact rename step to avoid unnecessary/unsafe moves during release builds.
Changes:
- Update
package.jsonversion from1.0.4to1.0.5. - Update CD workflow artifact rename logic to skip
mvwhen the destination artifact file already exists.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Version bump to 1.0.5 for the release. |
| .github/workflows/cd.yaml | Changes artifact rename behavior during the build job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| src="dist/github-code-search-$(echo '${{ matrix.target }}' | sed 's/^bun-//')" | ||
| [ -f "${src}.exe" ] && src="${src}.exe" | ||
| mv -fv "$src" "dist/${{ matrix.artifact }}" | ||
| [ -f "dist/${{ matrix.artifact }}" ] || mv -v "$src" "dist/${{ matrix.artifact }}" |
There was a problem hiding this comment.
The rename guard checks whether the destination file already exists, which can silently skip the move when the dest exists for reasons other than “src and dest are identical” (e.g., a leftover file), potentially uploading a stale artifact. Consider instead checking whether the computed src path equals the destination path and only skipping mv in that case; otherwise keep overwriting (mv -f) to ensure the artifact always matches the current build output.
| [ -f "dist/${{ matrix.artifact }}" ] || mv -v "$src" "dist/${{ matrix.artifact }}" | |
| dest="dist/${{ matrix.artifact }}" | |
| if [ "$src" != "$dest" ]; then | |
| mv -fv "$src" "$dest" | |
| fi |