Conversation
|
Coverage after merging release/1.8.3 into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
🔦 Lighthouse Report
|
There was a problem hiding this comment.
Pull request overview
This PR appears intended to publish the v1.8.3 release, but the diff currently only contains the version bump + release-note documentation updates (no TUI/layout source changes are present in the provided PR files).
Changes:
- Bump
package.jsonversion to 1.8.3. - Add a new blog post for the v1.8.3 release and link it from the blog index.
- Add a v1.8.3 entry to
CHANGELOG.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Updates the package version to 1.8.3. |
| docs/blog/release-v1-8-3.md | Adds v1.8.3 release notes post. |
| docs/blog/index.md | Adds v1.8.3 row linking to the new post. |
| CHANGELOG.md | Adds v1.8.3 link/summary row. |
| "name": "github-code-search", | ||
| "version": "1.8.2", | ||
| "version": "1.8.3", | ||
| "description": "Interactive GitHub code search with per-repo aggregation", |
There was a problem hiding this comment.
The PR description lists substantial changes in src/render.ts, src/render/rows.ts, and src/tui.ts, but this PR’s diff only shows a version bump + docs/changelog updates. Either include the missing source-code changes in this PR, or update the PR title/description so it accurately reflects what’s being merged.
|
|
||
| ## Upgrade | ||
|
|
||
| ```sh |
There was a problem hiding this comment.
For consistency with the other release posts in docs/blog/, the upgrade snippet should use a bash fenced block (bash) rather than sh.
| ```sh | |
| ```bash |
v1.8.3 — Fix TUI layout
Root cause
Three independent bugs in the TUI rendering pipeline:
clipAnsiadvanced byte-by-byte, splitting surrogate pairs / emoji at a raw byte boundary and producing garbled output.Changes
src/render.ts— header anchored above scroll region; footer preceded by blank-line padding (for (let i = usedLines; i < viewportHeight; i++) lines.push("")) to fill the viewport;clipAnsinow iterates withcodePointAtto advance by full Unicode code points and appends\x1b[22;39m(partial reset preserving background) instead of a full\x1b[0m;maxPathVisibleandmaxLeftVisiblefloors lowered toMath.max(1, ...); section labelmaxLabelCharsfloor lowered toMath.max(0, ...)with blank-line placeholders when 0.src/render/rows.ts— newnormalizeScrollOffset()pure function that decreases the scroll offset when the current position leaves blank space at the bottom of the viewport.src/tui.ts—normalizeScrollOffsetcalled in a fixed-point loop insideredraw()so the offset always fills the screen;getRepoRowIndexMaplazy O(1) Map replacing O(n)findIndex; title badge now renders aspc.bgMagenta(pc.black(pc.bold(...)))for maximum contrast.docs/blog/release-v1-8-3.md+docs/blog/index.md+CHANGELOG.md— release notes.Steps to reproduce (before the fix)
Steps to verify (after the fix)
Closes #105