feat(nycoa) Initial NY CoA support#1982
Draft
Brennan-Chesley-FLP wants to merge 1 commit into
Draft
Conversation
Brennan-Chesley-FLP
force-pushed
the
feat/kent-parser-tests
branch
from
a11d522 to
c88c80b
Compare
Brennan-Chesley-FLP
force-pushed
the
feat/nycoa-initial
branch
from
ea32833 to
c49ca39
Compare
Brennan-Chesley-FLP
force-pushed
the
feat/kent-parser-tests
branch
3 times, most recently
from
c490946 to
cb0d652
Compare
Brennan-Chesley-FLP
force-pushed
the
feat/nycoa-initial
branch
2 times, most recently
from
18f86a4 to
8a18327
Compare
Brennan-Chesley-FLP
force-pushed
the
feat/kent-parser-tests
branch
from
cb0d652 to
4b06fde
Compare
Brennan-Chesley-FLP
force-pushed
the
feat/nycoa-initial
branch
from
8a18327 to
49f4472
Compare
Brennan-Chesley-FLP
force-pushed
the
feat/nycoa-initial
branch
from
49f4472 to
ca9a854
Compare
| court_id: str = "ny" | ||
| """Court identifier""" | ||
|
|
||
| case_name: HarmonizedCaseName |
Contributor
Author
There was a problem hiding this comment.
Case name harmonization.
| decision_date: date | None = None | ||
| """Date of decision (decided cases only)""" | ||
|
|
||
| issues: list[CleanString] = [] |
Contributor
Author
There was a problem hiding this comment.
clean_html application.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft currently until the base is fixed up (kent released) and I think there's one more change I'd like to make to this. During development and data verification, I added a lot of checks and retry logic in here that were very useful for tracking down a concurrency bug in the scraper. It's possible that they can be used to get a little speedup for ongoing scrapes, but I'm about 90% sure that the speedup is marginal enough that it's just not worth it. I'm running a test overnight, and the scraper.py will probably get a big chunk removed and simplified based on the results of that.