-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Improve Rust scraper #2569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improve Rust scraper #2569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e193a88
to
97f7b5a
Compare
…so links inside SVGs, such as those in Rust's railroad diagrams, can work properly.
…this matches browsers' native behaviour.
simon04
reviewed
Sep 25, 2025
simon04
approved these changes
Sep 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements to the Rust scraper here. In screenshots, before is on the left, after is on the right.
Improve broken page names in Rust
As described in #2568:
..
on the beginning of their title.. The Rust Reference
Now, no empty dots, things in the intro of the book all get
00.00.
so they're sorted to the top, and pages in the Book and the Reference all get the correct title.Screenshots
Update to new compiler error codes location
It got moved, and is no longer all on one page.
Screenshot
Fix and style syntax definitions/diagrams in Rust Reference
The Rust Reference has syntax diagrams and definitions for a bunch of things, which were missing styles and elements before, and had a non-functional toggle button. I put them in a working
<details>
element and adapted SVG styles from the original.Screenshot
Note
This meant changing the global
CleantTextFilter
to include some SVG elements if they're empty. This affects all the docs, but I think in a mostly positive way. For instance, the Web APIs docs have some broken SVGs in them for this same reason:Screenshot
…however, I haven't verified that this will improve this exact case, because the MDN scraper appears to be broken at the moment. (It's broken on main as well)
I also made some modifications to the global link handling, because:
a
tags in an SVG don't behave quite like normal ones, so they would break history navigation<details>
element didn't open the<details>
, and I added a lot of those, so I implemented that.Remove visible anchor links from Rust Reference
These are hidden in the original docs, and they're all over the place:
Screenshot